Login UI collapsed on landscape orientation in mobile - Reported by: @Santhosh-Sellavel

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

User not signed in

1. Open app in portrait
2. Rotate app to landscape

Expected Result:

Screen should not be distorted or overlapping

Actual Result:

Text and modals overlap

Workaround:

Don't use landscape mode (?)

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.1.7-0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Uploading Bug5258104_IMG_1660.mp4…

Expensify/Expensify Issue URL:

Issue reported by: @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1634249361307200

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

Similar issue reported here #5159 which will handle this.

[Santhosh-Sellavel]

I'm not sure, how it will handle it #5159 (iPad). This is issue occurs on android devices.

[parasharrajat]

Because, IPad and Landscape mode both use the same code. Single UI change will fix both. The root cause of the both issues is the same. The solution I am going to drop covers this as well. In other words, no solution will be accepted for #5159 that does not fix this.

IMO, a single issue for the UI of the login page is sufficient.

[Santhosh-Sellavel]

The root cause of both issues is the same.

How you figured it out?

I don’t see any proposal that solves both as of now.

[marcaaron]

Here's my read on this... If we want to propose a solution that fixes the two issues that sounds fine. But the two issues appear to be different in this case.

• This issue shows collapsed and broken looking UI
• The other issue referenced shows the keyboard covering the input

Those might share a root cause, but they are two distinct issues. If there's a solution that covers both and they truly have the same root cause that's great! But there's no harm in having two issues open which track separate things. We can just close them together if one solution is best.

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[marcaaron]

Hey @puneetlath unsure if we want to create a new job for this or to see where the conversation above evolves, but I will leave that up to you.

[parasharrajat]

Yup. We should keep this open and wait on another one. I will submit the PR in 2 days for another one.

[MelvinBot]

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[puneetlath]

Sounds good, let's wait to see the result of the other one.

@stephanieelliott FYI I reapplied the External label since I'll be ooo then.

[MelvinBot]

@stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[stephanieelliott]

Still waiting on this!

[stephanieelliott]

Removing daily label as we're just tracking for the moment.

[stephanieelliott]

Still waiting to see if #5159 resolves

[stephanieelliott]

PR is up for #5159, waiting on #6203 so we can reuse components.

[stephanieelliott]

#5159, is in review, seems like we are waiting for that to see if it solves the issue.

[stephanieelliott]

#5159, still open

[stephanieelliott]

Still on hold pending resolution of #5159

[stephanieelliott]

Still on hold pending resolution of #5159

[stephanieelliott]

Still holding.

[stephanieelliott]

Still holding, PR for #5159 is under review.

[stephanieelliott]

#5159 is still open, still holding on this one.

[stephanieelliott]

The PR for #5159 was merged (#6137), as well as PR #6203, which we were waiting on to see if they resolved this. Just tested on iOS (both web and app) and did not encounter the issue, it seems like this one is fixed.