Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2021-10-30] Log in - Promo Colors are changing each time the user writes a new character for new password #5912

Closed
isagoico opened this issue Oct 16, 2021 · 9 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to log in screen
  2. Enter a new email
  3. Look for the validation mail on email inbox
  4. Change link to staging
  5. Write some characters in password fields
  6. Dance 💃

Expected Result:

Colors should not change with each character written

Actual Result:

Colors are changing with each character written

Workaround:

None needed, visual issue.

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: 1.1.8-2

Reproducible in staging?: Yes
Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Grabando.227.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@isagoico isagoico added DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 labels Oct 16, 2021
@MelvinBot
Copy link

Triggered auto assignment to @Jag96 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@rushatgabhane
Copy link
Member

In the interest of time, pushed a PR that fixes this issue.

@Jag96
Copy link
Contributor

Jag96 commented Oct 18, 2021

@rushatgabhane thanks for helping to get this fixed so quickly! I'll review the PR and create an Upwork job to get you hired for this one

@Jag96 Jag96 added the Reviewing Has a PR in review label Oct 18, 2021
@rushatgabhane
Copy link
Member

Thanks! @ Jag96

@Jag96
Copy link
Contributor

Jag96 commented Oct 18, 2021

Removing deployblocker label since the fix is now on staging, adding Exported label to add the awaiting payment label when this is deployed to prod.

@Jag96 Jag96 added Exported and removed DeployBlockerCash This issue or pull request should block deployment labels Oct 18, 2021
@MelvinBot MelvinBot added the Weekly KSv2 label Oct 18, 2021
@botify botify added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 Hourly KSv2 labels Oct 23, 2021
@botify botify changed the title Log in - Promo Colors are changing each time the user writes a new character for new password [HOLD for payment 2021-10-30] Log in - Promo Colors are changing each time the user writes a new character for new password Oct 23, 2021
@botify
Copy link

botify commented Oct 23, 2021

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.8-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2021-10-30. 🎊

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First Week)

@Jag96
Copy link
Contributor

Jag96 commented Nov 1, 2021

Paid!

@Jag96 Jag96 closed this as completed Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants