Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Company cards - Netsuite - Card details page opened when going back from Netsuite Export settings page #55752

Open
1 of 8 tasks
vincdargento opened this issue Jan 24, 2025 · 3 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@vincdargento
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.89-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+ccardfeed@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome
App Component: Workspace Settings

Action Performed:

Pre-requisite:

  • User must have assigned a few company cards
  • User have enable Accounting and connected to Netsuite
  1. Go to Workspace settings > Company cards
  2. Click on an assigned card
  3. Click on the export option row (vendor bill, journal entries)
  4. Click on "export option" highlighted text in the subheader.
  5. Click on the back arrow.

Expected Result:

User should land on the card-level export page

Actual Result:

User lands in the card details page

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bandicam.2025-01-24.16-02-08-243.mp4

View all open jobs on GitHub

@vincdargento vincdargento added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 24, 2025
Copy link

melvin-bot bot commented Jan 24, 2025

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@isagoico
Copy link

isagoico commented Jan 24, 2025

@joekaufmanexpensify We found this issue when writing the TestRail regression steps for Company Cards

@FitseTLT
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Company cards - Netsuite - Card details page opened when going back from Netsuite Export settings page

What is the root cause of that problem?

We are passing the backTo of WorkspaceCompanyCardAccountSelectCardPage for the menu items here

const exportMenuItem = getExportMenuItem(connectedIntegration, policyID, translate, policy, card, backTo);

What changes do you think we should make in order to solve the problem?

We should pass the current active route as the backTo

    const exportMenuItem = getExportMenuItem(connectedIntegration, policyID, translate, policy, card, Navigation.getActiveRoute());

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants