Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank account - Blank validation page displayed #5290

Closed
kavimuru opened this issue Sep 16, 2021 · 15 comments
Closed

Bank account - Blank validation page displayed #5290

kavimuru opened this issue Sep 16, 2021 · 15 comments
Assignees
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #5251

Action Performed:

  1. Create a new user
  2. Create workspace via the global create menu
  3. Select 'Get Started' after the workspace is created
  4. Go through VBA setup using the test credentials in , and arrive at Validate step

Expected Result:

There should be no animated image
There should be a button at the bottom marked 'Got it'

Actual Result:

Blank validation page displayed

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.0.99-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5238795_Screen_Shot_2021-09-15_at_7 40 20_PM

Bug5238795_Validate.mp4

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Sep 16, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kavimuru
Copy link
Author

kavimuru commented Sep 16, 2021

We could not test in production as these credentials will work only in staging.

@MariaHCD
Copy link
Contributor

cc: @Julesssss I think this may be related to #5251

@Julesssss
Copy link
Contributor

Thanks, I think you're right -- but have no idea why this wasn't seen during development 😕

@Julesssss
Copy link
Contributor

I will deal with this after I resolve this other deployBlocker: #5291

@MariaHCD MariaHCD assigned Julesssss and unassigned MariaHCD Sep 16, 2021
@Julesssss
Copy link
Contributor

Julesssss commented Sep 16, 2021

Unable to reproduce currently on dev. Working on testing this on staging, but I'm struggling to find an account that lets me set up a workspace.

Screenshot 2021-09-16 at 15 43 34

@Julesssss
Copy link
Contributor

Julesssss commented Sep 16, 2021

I was blocked for a while by Onfido, but managed to pass the check using an iPhone. Unable to reproduce this bug on staging, version v1.0.99-1:

VBAValidate.mov

@Julesssss
Copy link
Contributor

Mabe it's unique to safari

@MitchExpensify
Copy link
Contributor

MitchExpensify commented Sep 16, 2021

I was able to reproduce on staging on Safari by following #1 in the SO except I copied @Julesssss and did not use REAL credentials in the personal info step:
image

Interestingly, when I exited the flow I saw the expected Concierge message and when I re-entered the add bank account flow I saw the expected Validate screen message:

image

Separately, I was unable to reproduce on production. Using the same creds, I reached the expected Validate screen here:
image

@Julesssss
Copy link
Contributor

Thanks, @MitchExpensify! I suggest we revert this PR while I figure out how to reproduce on dev.

@Julesssss
Copy link
Contributor

Raised a revert PR here, I'll try to reproduce this and fix locally tomorrow.

@Julesssss
Copy link
Contributor

Hmm, this might actually be a duplicate of this issue. Trying to verify.

@Julesssss
Copy link
Contributor

Struggling to verify this locally. Even though I think the UI changes have not triggered this regression I think to help with debugging we should merge the revert. This will mean that we can test this issue repeatedly on staging.

@Julesssss Julesssss added Daily KSv2 and removed Hourly KSv2 labels Sep 17, 2021
@Julesssss
Copy link
Contributor

Closing this issue as we are fairly certain that the issue was already occurring here. Slack discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering
Projects
None yet
Development

No branches or pull requests

6 participants