Group chat - Blank name in "This chat is with " when creating group chat with yourself

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Start chat.
3. Click Add to group next to any user.
4. Click Next.
5. Unselect the user on the confirmation page.
6. Click Start group.

Expected Result:

The copy at the beginning of the conversation should include the current user.

Actual Result:

The copy at the beginning of the conversation is "This chat is with " which shows blank name.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6628148_1728379695818.20241008_172523.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-10-08 10:29:59 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Blank name in "This chat is with " when creating group chat with yourself

What is the root cause of that problem?

From here we get the participant accountID and we pass true for shouldForceExcludeCurrentUser

App/src/libs/SidebarUtils.ts

Line 552 in 016822b

const participantAccountIDs = ReportUtils.getParticipantsAccountIDsForDisplay(report, undefined, undefined, true);

and in here we use shouldExcludeCurrentUser which will be true cause we are passing true for shouldForceExcludeCurrentUser

App/src/libs/ReportUtils.ts

Line 2129 in 016822b

const shouldExcludeCurrentUser = isOneOnOneChat(report) || isSystemChat(report) || shouldForceExcludeCurrentUser;

What changes do you think we should make in order to solve the problem?

We can use isGroupchat check here

    const isGroupChat = ReportUtils.isGroupChat(report)

If isGroupChat is true we can pass false for shouldForceExcludeCurrentUser.

What alternative solutions did you explore? (Optional)

Alternative solution would be not to add any check

App/src/libs/SidebarUtils.ts

Line 552 in 016822b

const participantAccountIDs = ReportUtils.getParticipantsAccountIDsForDisplay(report, undefined, undefined, true);

    const participantAccountIDs = ReportUtils.getParticipantsAccountIDsForDisplay(report, undefined, undefined);

Alternative 2
Or we could simply add !isGroupChat here

      const shouldExcludeCurrentUser = isOneOnOneChat(report) || isSystemChat(report) || (shouldForceExcludeCurrentUser && !isGroupChat(report));