Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate workflow job failing on main: test / test (job 2) #49606

Open
github-actions bot opened this issue Sep 23, 2024 · 8 comments
Open

Investigate workflow job failing on main: test / test (job 2) #49606

github-actions bot opened this issue Sep 23, 2024 · 8 comments
Assignees
Labels

Comments

@github-actions
Copy link
Contributor

🚨 Failure Summary 🚨:

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named test / test (job 2).
This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

  1. Why the PR caused the job to fail?
  2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

@flodnv
Copy link
Contributor

flodnv commented Sep 24, 2024

@nkdengineer any idea what's going on here? 😕

@nkdengineer
Copy link
Contributor

@flodnv This is not a problem from our PR. This test also fails on the latest main.

@flodnv
Copy link
Contributor

flodnv commented Sep 24, 2024

@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@flodnv flodnv assigned VickyStash and unassigned flodnv Sep 24, 2024
@flodnv flodnv added Daily KSv2 and removed Hourly KSv2 labels Sep 24, 2024
@VickyStash
Copy link
Contributor

Updates: I've prepared the Draft PR that fixes the test.
However I want to spend a little bit more time tomorrow to find out why the test has started to fail only lately to make sure that everything is correct.

@VickyStash
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

The PaginationTest started to fail randomly on the main.
The reason for failing the test is that the part of newer report actions is not loaded:
image

What is the root cause of that problem?

A couple of days ago the PR, which updates the way new messages are loaded, was merged.

const onStartReached = useCallback(() => {
InteractionManager.runAfterInteractions(() => requestAnimationFrame(() => loadNewerChats(false)));
}, [loadNewerChats]);

The InteractionManager.runAfterInteractions adds a small delay in the new messages loading which makes the test fail.

What changes do you think we should make in order to solve the problem?

Update the failing test to include the await waitForBatchedUpdatesWithAct(); after scrolling event to let the test wait for the new messages loading.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 25, 2024
@VickyStash
Copy link
Contributor

I've opened the PR for the review!
cc @flodnv @mountiny

Copy link

melvin-bot bot commented Sep 25, 2024

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants