[$50] [Search v2.3] - Long list causes overlap with status bar on native, and unscrollable on mweb

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• There is a long list of saved search until the dropdown list is scrollable.

1. Launch New Expensify app.
2. Go to Search.
3. Tap on the dropdown.
4. Note that the selected Expenses tab overlaps with the status bar.
5. Go to staging new dot mobile web.
6. Go to Search.
7. Tap on the dropdown.
8. Note that the page cannot be scrolled on mobile web.

Expected Result:

In Step 4, the selected Expenses tab will not overlap with the status bar.
In Step 8, the list is scrollable on mobile web.

Actual Result:

In Step 4, the selected Expenses tab overlaps with the status bar.
In Step 8, the list is not scrollable on mobile web.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6603226_1726299984928.ScreenRecording_09-14-2024_15-40-47_1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[ishpaul777]

Edited by proposal-police: This proposal was edited at 2024-09-14 21:40:49 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Saved search - Long list causes overlap with status bar on native, and unscrollable on mweb

What is the root cause of that problem?

In c04e7a1, we added a scrollview in PopoverMenu to make it scrollable, but height for menu is not capped, so it can go beyond the screen height and overlap with status bar on native, and be unscrollable on mweb

App/src/components/PopoverMenu.tsx

Line 259 in 0c618ac

<ScrollView style={isSmallScreenWidth ? {} : styles.createMenuContainer}>

What changes do you think we should make in order to solve the problem?

we need to set a max height for the menu so it doesn't go beyond the screen height. (we'll add this in a new style), we'll also need to confirm the upper margin value from design team. for now, its 200 as a placeholder.

    const {windowHeight} = useWindowDimensions();

    <ScrollView style={isSmallScreenWidth ? {maxHeight: windowHeight - 200} : createMenuContainer}>

Mweb

Screen.Recording.2024-09-15.at.3.07.18.AM.mov

ios Native

Screen.Recording.2024-09-15.at.2.59.32.AM.mov

[luacmartins]

@lakchote will address this in a follow up from his PR

[luacmartins]

Fixed on staging.

[luacmartins]

Reopening to compensate @ishpaul777 $50 since his solution was used to solve this issue.

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[trjExpensify]

Offer sent to Ishpaul for $50 for the proposal.

[trjExpensify]

Paid!