-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close reports for the combo of Instant Submit + No Approvals + No Payments #49131
Comments
Triggered auto assignment to @alexpensify ( |
Because of a couple of other bugs atm we're working on elsewhere, you might want to switch to OldDot settings to get your workspace into the correct state to develop with @srikarparsi, or basically these are the three important properties on the workspace for the right condition:
|
Awesome, I was able to replicate this pretty easily using @garrettmknight's steps in the issue body, didn't have to do anything in Old Dot. We just don't want the "Waiting for Srikar to pay expense(s)" because payments is not enabled right. |
Ah yeah, I mean it's impossible in NewDot to get the workspace into that state because of the bugs. So if you need to to test what happens to the report state when all of those three are set as such, you can get the config there via OldDot.
I think you've figured out since that the nextSteps text isn't the only scope of what's wrong with this issue. The underlying report is in the |
@garrettmknight Can you assign me this issue as reviewer? |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: N/A
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: @garrettmknight
Slack conversation: https://expensify.slack.com/archives/C06ML6X0W9L/p1726136887331749?thread_ts=1725892977.799399&cid=C06ML6X0W9L
Action Performed:
Expected Result:
Since there is no approval or payment action for anyone to take, the report should be
Closed
. This will result in each individual expense in this configuration creating a closed report.Actual Result:
The expense is added to a report in the Processing state with inaccurate next steps:
Waiting for [workspace admin] to pay expense(s).
Workaround:
No workaround.
Platform:
All
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @srikarparsiThe text was updated successfully, but these errors were encountered: