[$250] Category rules - Description for Individual expense in "Flags amount over" is truncated

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.32-1
Reproducible in staging?: Y
Reproducible in production?: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Rules feature is enabled.

1. Go to staging.new.expensify.com
2. Go to Workspace settings > Categories.
3. Click on any category.
4. Click Flag amounts over.
5. Click Type.

Expected Result:

The description for Individual expense should not be truncated.
We can compare this long description with "Smart Limit" description in Expensify Card > Limit type page, which is not truncated.

Actual Result:

The description for Individual expense is truncated.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6599805_1726054315145.20240911_192708.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834225539612184157
• Upwork Job ID: 1834225539612184157
• Last Price Increase: 2024-09-12

Issue Owner

Current Issue Owner: @ikevin127

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Description for Individual expense in "Flags amount over" is truncated

What is the root cause of that problem?

We don't pass isAlternateTextMultilineSupported here like we did here

What changes do you think we should make in order to solve the problem?

Pass isAlternateTextMultilineSupported here

                <SelectionList
                    sections={[{data: expenseLimitTypes}]}
                    ListItem={RadioListItem}
                    onSelectRow={(item) => onExpenseLimitTypeSelected(item.value)}
                    shouldSingleExecuteRowSelect
                    containerStyle={[styles.pt3]}
                    initiallyFocusedOptionKey={currentExpenseLimitType}
                    isAlternateTextMultilineSupported
                />

What alternative solutions did you explore? (Optional)

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Description for Individual expense in "Flags amount over" is truncated

What is the root cause of that problem?

We are not passing isAlternateTextMultilineSupported and alternateTextNumberOfLines={0} here

App/src/pages/workspace/categories/ExpenseLimitTypeSelector/ExpenseLimitTypeSelectorModal.tsx

Lines 61 to 65 in e9642dc

	<SelectionList
	sections={[{data: expenseLimitTypes}]}
	ListItem={RadioListItem}
	onSelectRow={(item) => onExpenseLimitTypeSelected(item.value)}
	shouldSingleExecuteRowSelect

What changes do you think we should make in order to solve the problem?

Pass isAlternateTextMultilineSupported and alternateTextNumberOfLines={0}

<SelectionList
                    sections={[{data: expenseLimitTypes}]}
                    alternateTextNumberOfLines={0}
                    ListItem={RadioListItem}
                    onSelectRow={(item) => onExpenseLimitTypeSelected(item.value)}
                    shouldSingleExecuteRowSelect
                    containerStyle={[styles.pt3]}
                    initiallyFocusedOptionKey={currentExpenseLimitType}
                    isAlternateTextMultilineSupported

Note: If we don't pass alternateTextNumberOfLines={0}, the alternate text will be truncated to 2 lines

Result when we don't add alternateTextNumberOfLines={0

Result

What alternative solutions did you explore? (Optional)

[arosiclair]

Very minor so not a blocker

[arosiclair]

Looks like this was just implemented in #48171. @WojtekBoman can you clean this up?

[WojtekBoman]

Sure, I'll fix that :)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021834225539612184157

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[melvin-bot]

@arosiclair, @WojtekBoman, @VictoriaExpensify, @eh2077 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@arosiclair, @WojtekBoman, @VictoriaExpensify, @eh2077 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[VictoriaExpensify]

@arosiclair - if this has been fixed here are we ok to close this out?

[arosiclair]

Yeah looks like that PR fixed both issues. Lets leave the other issue to issue payment for the review.