[$250] Copilot - "Learn more" link is out of place

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.32-0
Reproducible in staging?: Y
Reproducible in production?: N/A
Issue was found when executing this PR: #47353
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Login to Expensifail account
2. Settings > Security
   Notice the "learn more" link is out of place

Expected Result:

Correct placement of the link

Actual Result:

The "learn more" link is out of place

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833989038851077832
• Upwork Job ID: 1833989038851077832
• Last Price Increase: 2024-09-18

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Learn more" link is out of place

What is the root cause of that problem?

We display the copilotDelegatedAccessDescription text and learnMore text link side by side, so on small width screen both text and text link width will narrower

What changes do you think we should make in order to solve the problem?

Put the learnMore text link inside the copilotDelegatedAccessDescription text here

<Text style={[styles.textNormal, styles.colorMuted]}>
      {translate('delegate.copilotDelegatedAccessDescription')} 
      <TextLink
          style={[styles.link]}
          href={CONST.COPILOT_HELP_URL}
      >
          {translate('common.learnMore')}
      </TextLink>
  </Text>

What alternative solutions did you explore? (Optional)

[mountiny]

@rushatgabhane another one from copilot

demoting as its behind beta

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021833989038851077832

[melvin-bot]

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

[kevinksullivan]

Moving forward and putting in control wave

[kevinksullivan]

Looping in another BZ as I'm going OOO

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ra-md]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Learn more" link is misaligned on narrow screens.

What is the root cause of that problem?

The issue lies with the parent of Text "copilotDelegatedAccessDescription" and TextLink "learnMore," which use flex and flex-row, causing them to align in a row. While this works well on a wide screen, on a narrow screen, it misaligns TextLink "learnMore," which should be positioned next to the word "account."

What changes do you think we should make in order to solve the problem?

Replace View with Text. A similar approach is used here and here.

<Text style={[styles.flexRow, styles.alignItemsCenter, styles.w100, styles.mt2]}>
    <Text style={[styles.textNormal, styles.colorMuted]}>{translate('delegate.copilotDelegatedAccessDescription')} </Text>
    <TextLink
        style={[styles.link]}
        href={CONST.COPILOT_HELP_URL}
    >
        {translate('common.learnMore')}
    </TextLink>
</Text>

What alternative solutions did you explore? (Optional)

[greg-schroeder]

Are we awaiting proposal review, or is this already being fixed by #48517?

[rushatgabhane]

no it is fixed in the PR above

[greg-schroeder]

Okay got it, thanks! PR in review then

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸