Expense - Green checkmark is shown on the right end of Amount row and not next to Amount

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.32-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/4945103
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. [User A] Submit an expense to User B.
3. [User B] Pay the expense.
4. [User A & User B] Go to the transaction thread.

Expected Result:

Green checkmark will be shown next to the paid amount in the transaction thread (production behavior).

Actual Result:

Green checkmark is shown on the right end of Amount row in the transaction thread.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6599560_1726029695641.20240911_123854.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Nodebrute]

Regression from #48456

[Nodebrute]

@Guccio163 @rayane-djouah

[rayane-djouah]

Thanks @Nodebrute

[rayane-djouah]

@Guccio163 does this have the same root cause with #48964?

[Guccio163]

Yeahhhhhh, I think we can't fix this one with anything else than setting that flex: 0. That brings the question: shouldn't we just try to add flex: 1 specifically to filters' MenuItem? This would solve all the issues that were just raised

[rayane-djouah]

shouldn't we just try to add flex: 1 specifically to filters' MenuItem? This would solve all the issues that were just raised

I agree, let's do it!

[Guccio163]

Great, I moved flex: 1 directly to Advanced Filters file, is this the result that satisfies us @rayane-djouah?

If yes, I'll quickly add a PR 😉

[rayane-djouah]

@Guccio163 looks good!

[Guccio163]

PR above solves this issue once it's merged, because it reverts previous interference on MenuItem and hence this section, result is right:

Screen.Recording.2024-09-11.at.13.47.15.mov

[Guccio163]

PR is merged, this issue can be closed