[HOLD for payment 2024-09-18] [Search v2.2] Deleted message changes to empty content with (edited) in Search - Chat page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.31-0
Reproducible in staging?: Y
Reproducible in production?: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to DM.
3. Send a message.
4. Go to Search > Chat.
5. Go to Sent.
6. Click on the message sent in Step 3.
7. Send another message in report RHP.
8. Delete the first message sent in Step 3.

Expected Result:

The deleted message will be removed from Search - Chat page.

Actual Result:

The deleted message changes to empty content with (edited) in Search - Chat page.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6597777_1725902332343.20240910_010857.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[etCoderDysto]

Edited by proposal-police: This proposal was edited at 2024-09-09 18:50:51 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Deleted message changes to empty content with (edited) in Search - Chat page

What is the root cause of that problem?

We are not checking if a reportAction is deleted before adding it to reportActionItems

App/src/libs/SearchUtils.ts

Lines 203 to 209 in 61ee515

	reportActionItems.push({
	...reportAction,
	from,
	formattedFrom: from?.displayName ?? from?.login ?? '',
	date: reportAction.created,
	keyForList: reportAction.reportActionID,
	});

What changes do you think we should make in order to solve the problem?

We should check if a report action is deleted before adding it to reportActionItems

const isDeleted = isDeletedAction(reportAction);
if (!isDeleted) {
        const from = data.personalDetailsList?.[reportAction.accountID];
       reportActionItems.push({
      ...reportAction,
      from,
      formattedFrom: from?.displayName ?? from?.login ?? '',
      date: reportAction.created,
      keyForList: reportAction.reportActionID,
     });
}

What alternative solutions did you explore? (Optional)

We can use shouldReportActionBeVisible to cover other cases in adition to deleted messages

const shouldShowReportAction = ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID);
if (shouldShowReportAction) {
  reportActionItems.push({
      ...reportAction,
      from,
      formattedFrom: from?.displayName ?? from?.login ?? '',
      date: reportAction.created,
      keyForList: reportAction.reportActionID,
     });
}

[luacmartins]

I'll take this since it's part of Search. cc @shubham1206agra @ikevin127

[luacmartins]

CPing fix

[luacmartins]

Fixed in staging.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.31-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix deleted message on search #48842

If no regressions arise, payment will be issued on 2024-09-18. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@luacmartins] Determine if we should create a regression test for this bug.
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: