[$250] [Search v2.1] Search loads infinitely when search filter has tax rate in A: B name format

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.27-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Taxes
3. Add a tax rate with A: B as name and any rate
4. Go to Search
5. Click Filters
6. Click Tax rate
7. Select the tax rate with A: B name
8. Click Save
9. Click View results

Expected Result:

Search will not load infinitely

Actual Result:

Search loads infinitely when search filter has tax rate in A: B name format

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6590496_1725281171180.20240902_204541.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831467372268005074
• Upwork Job ID: 1831467372268005074
• Last Price Increase: 2024-09-04

Issue Owner

Current Issue Owner: @rushatgabhane

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Edited by proposal-police: This proposal was edited at 2023-10-06T12:00:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search loads infinitely when enter tax rate with A: B format.

What is the root cause of that problem?

When we create a tax rate with the name of A: B, the tax code becomes id_A:_B

Filtering tax code will filter based on the tax code and because it contains a colon :, the parser considered it as an AND operator.

And the BE will eventually return an error.

This happens if we filter based on other things too if we include : without a space.

What changes do you think we should make in order to solve the problem?

We need to sanitize the string if it contains : just like we did when it contains a space or comma.

App/src/libs/SearchUtils.ts

Lines 411 to 416 in 9aca655

	function sanitizeString(str: string) {
	if (str.includes(' ') || str.includes(',')) {
	return `"${str}"`;
	}
	return str;
	}

The sanitation will wrap the keyword with ".

There is also another issue I notice where if we switch to inbox and then back to search, the issue happens again. To fix that, we need to also sanitize the string here.

App/src/libs/SearchUtils.ts

Line 559 in 9aca655

filterValueString += ` ${filterName}${operatorToSignMap[queryFilter.operator]}${queryFilter.value}`;

filterValueString += ` ${filterName}${operatorToSignMap[queryFilter.operator]}${sanitizeString(queryFilter.value.toString())}`;

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021831467372268005074

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[VictoriaExpensify]

Agree this is an issue and it should be fixed

[ghost]

Edited by proposal-police: This proposal was edited at 2024-09-05 09:48:16 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Certain characters, and sequences of characters, in the Name field of Taxes and categories like Merchants cause the search/filter to load indefinitely, along with other issues such as displaying of the filtered term.

What is the root cause of that problem?

Input for the Name field is insufficiently validated, and only slightly sanitized for spaces and commas.

What changes do you think we should make in order to solve the problem?

Validate input for the Name field. More concretely, reject input with malicious characters, malicious character sequences, and most characters that break search/filter. Sanitize a limited set of non malicious characters, like comma and blank space, and ensured they display correctly.

What alternative solutions did you explore? (Optional)

[trjExpensify]

Moving to wave-control, as it's search related. CC: @luacmartins for vis

[luacmartins]

I think this may be solved once we update the syntax grammar in this PR

[luacmartins]

This is being solved here

[VictoriaExpensify]

Closing this out since this has been solved