[AWAITING PAYMENT] [$250] Chat - Cursor moves before the emoji after adding it by typing on a second line

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.25-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4895999
Email or phone of affected tester (no customers): gatantm@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch new expensify and open any chat
2. Press enter so there is an empty first line
3. On the second line, type ✋ and continue typing after the emoji is typed

Expected Result:

The cursor goes after the emoji after adding it with its complete code

Actual Result:

The cursor goes before the just typed emoji, When typing one letter will go before the emoji and the rest after it. It also removes the previous line or if enter is pressed the message is sent instead of adding a new line

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6583730_1724720178190.RPReplay_Final1724720094.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c2f983ff6514acbf
• Upwork Job ID: 1828458402364890340
• Last Price Increase: 2024-08-27

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[NikkiWines]

Hmm, I'm not able to reproduce this on dev (9.0.25-1) and I don't see to have 9.0.25-0 on testflight yet

screen-rec.mp4

[garrettmknight]

Also can't repro on 9.0.25-1. Closing for now.

[IuliiaHerets]

@garrettmknight @NikkiWines The tester added an additional step, issue is still repro on mWeb Chrome Android and Safari iOS.
Steps:

1. Launch new expensify and open any chat
2. Add a second line of text
3. Type ✋ and continue typing after the emoji is typed

[garrettmknight]

@IuliiaHerets I still can't repro on mobile web. Is this an android only bug?

[NikkiWines]

I also can't reproduce on iOS

Simulator.Screen.Recording.-.iPhone.15.-.2024-08-27.at.16.57.06.mp4

[NikkiWines]

Trying android now

[IuliiaHerets]

@garrettmknight @NikkiWines I can repro on iOS/Safari , so not only Android bug

RPReplay_Final1724770058.MP4

[NikkiWines]

Hmm ok, I can't reproduce on dev but I can reproduce on staging mWeb actually - let's see if anything went out on the deploy that would impact this.

[NikkiWines]

Also i maybe suspect whatever is causing this is also causing #48051

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c2f983ff6514acbf

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[Skalakid]

@NikkiWines @IuliiaHerets I can't reproduce this issue on the latest staging version 9.0.25-10 iOS/mWeb. There is a chance that other PR just fixed it

Screen.Recording.2024-08-28.at.09.14.11.mov

[mountiny]

@Skalakid, I can still repro; please note it's crucial you leave the first line empty and press enter. Then on the second line this will fail:

RPReplay_Final1724833675.MP4

[Skalakid]

Okayy, thank you. It's not reproducible when using iOS simulator with connected hardware keyboard. When I use normal iOS keyboard the bug occurs

Screen.Recording.2024-08-28.at.10.56.58.mov

[Skalakid]

After investigation my Live Markdown refactor follow-up PR and one small fix fixed the problem. Once the second PR is merged, I will create the PR in E/App with the library bump

Screen.Recording.2024-08-28.at.11.33.02.mov

[Skalakid]

Hello, here is a PR with a fix in E/App 😄

[Skalakid]

Waiting for the review from @eVoloshchak

[Skalakid]

The PR has been merged :D

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[garrettmknight]

Wow, this one is way late.

@eVoloshchak can you complete the checklist and request payment when you're ready?

[garrettmknight]

Payment Summary:

• Reviewer: @eVoloshchak $250

[melvin-bot]

This issue has not been updated in over 15 days. @garrettmknight, @eVoloshchak, @NikkiWines, @Skalakid eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: this wasn't a bug in New Expensify, this was a bug in react-native-live-markdown library
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed, we already have the necessary check in the reviewer checklist

Regression Test Proposal

1. Open any chat
2. Press enter so there is an empty first line
3. On the second line, enter an emoji (using keyboard, for instance :hand) and continue typing after the emoji is typed
4. Verify that the cursor position is correct

Do we agree 👍 or 👎

[JmillsExpensify]

$250 approved for @eVoloshchak