[HOLD for payment 2024-09-06][Search v2.1] Add Filters button to Search page

[luacmartins]

We should add the Filters button to the Search page header so users can navigate to the Filters page

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

[dubielzyk-expensify]

Looks good on desktop:

This happens on mobile though:
You tap the filter button and you get a brief flash of the most recent chat before the filter screen appears:

CleanShot.2024-08-26.at.14.47.31.mp4

cc @Expensify/design

[shawnborton]

Good catch.

Also is it just me, or are the two button background colors different from one another?

[shawnborton]

(Actually we should probably leave this feedback in the PR itself)

[luacmartins]

Hahah yea, leaving the comments on the PR would be great. The PR was merged earlier today.

You tap the filter button and you get a brief flash of the most recent chat before the filter screen appears:

I couldn't reproduce this locally. I'll try again in staging once this PR is deployed

Also is it just me, or are the two button background colors different from one another?

I see both with background-color: rgb(230, 225, 218) so they seem to match.

[rayane-djouah]

⚠️ We just got confirmation on Slack that the Deploy Checklist: New Expensify 2024-08-26 which includes the PR of this issue was only deployed to production in Deploy Checklist: New Expensify 2024-08-28. More context on why this happened can be found in this Slack thread and this Slack comment.

Given the context above, this issue should be on [HOLD for Payment 2024-09-6] according to production deploy from Deploy Checklist: New Expensify 2024-08-28.

cc @stephanieelliott

[dubielzyk-expensify]

Yeah, even when I overlay them they seem to be the same color

[luacmartins]

Not overdue. Payment is due on the 6th

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @rayane-djouah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@stephanieelliott)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[stephanieelliott]

Summarizing payment on this issue

• Contributor: N/A internal
• Contributor+: @rayane-djouah $250 via Upwork -- I extended an offer to you, please accept when you get a chance! https://www.upwork.com/nx/wm/offer/103853895

Upwork job is here: https://www.upwork.com/jobs/~021832241147302028347

[rayane-djouah]

PR with no testing so the rate is $125

@stephanieelliott - The PR actually required testing, so I believe the reward should remain at the standard rate of $250.

I've accepted the job offer, thank you!

[stephanieelliott]

Ah ok, thanks for the correction @rayane-djouah. I added an additional $125 milestone to the job, so the entire job should be $250. Both have been paid!