[$250] Search - App returns to expense report on Inbox after editing report field in Search

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.21-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Workspace has report fields.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit two expenses.
4. Go to Search.
5. Go to Drafts.
6. Click on the View button next to the report title.
7. Click on any report field.
8. Edit the report field and save it.

Expected Result:

App will remain on the expense report RHP on Search after editing report field.

Actual Result:

App returns to the expense report on Inbox after editing report field in Search.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6573632_1723790005962.20240816_142832.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018b90139d632f76bb
• Upwork Job ID: 1826366986418491339
• Last Price Increase: 2024-08-21

Issue Owner

Current Issue Owner: @s77rt

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App return to the expense report after updating money report fields.

What is the root cause of that problem?

When we submit the report fields edit, dismiss the modal with the expense report ID if it's not a report title.

App/src/pages/EditReportFieldPage.tsx

Lines 78 to 84 in 5d09846

	if (isReportFieldTitle) {
	ReportActions.updateReportName(report.reportID, value, report.reportName ?? '');
	Navigation.goBack();
	} else {
	ReportActions.updateReportField(report.reportID, {...reportField, value: value === '' ? null : value}, reportField);
	Navigation.dismissModal(report?.reportID);
	}

What changes do you think we should make in order to solve the problem?

Use goBack instead.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns to the expense report on Inbox after editing report field in Search.

What is the root cause of that problem?

After we edit the report field, we dismiss the modal with reportID as the expense report then we will close the edit report field page and move to the report screen.

App/src/pages/EditReportFieldPage.tsx

Line 83 in 5d09846

Navigation.dismissModal(report?.reportID);

The same problem with the delete case

App/src/pages/EditReportFieldPage.tsx

Line 90 in 5d09846

Navigation.dismissModal(report?.reportID);

What changes do you think we should make in order to solve the problem?

We should just use go back as we do in the money request flow here

OPTIONAL: we can add the fallback route to the expense report

App/src/pages/EditReportFieldPage.tsx

Line 83 in 5d09846

Navigation.dismissModal(report?.reportID);

App/src/pages/EditReportFieldPage.tsx

Line 90 in 5d09846

Navigation.dismissModal(report?.reportID);

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@greg-schroeder Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018b90139d632f76bb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

Looks like a dupe #47179

[ikevin127]

✅ Issue was addressed in already opened PR #47721 (comment) that is soon to be merged.

[s77rt]

@greg-schroeder Let's close this

[greg-schroeder]

done

[bernhardoj]

@greg-schroeder after updating the report fields, it doesn't navigate to the large expense report screen, but it still closes the report RHP.

web.mp4