Search-Expense report opens instead of transaction thread when expense with comment is deleted

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.21-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Submit two expenses to any user.
3. Go to transaction thread of second expense.
4. Send a reply and delete the expense.
5. Go to Search.
6. Click on the first expense submitted in Step 2.

Expected Result:

The transaction thread should open.

Actual Result:

The expense report opens.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6573414_1723762324527.20240816_064726.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[MonilBhavsar]

cc @luacmartins since you're working on Search and seems to be coming from #46324.
I believe this is backend back. We need to account for deleted transactions on the server side

[luacmartins]

I don't think this is a blocker. We can still access the data, just one level deeper. I'll look into a backend solution for this.

[MonilBhavsar]

Thanks Carlos! Should I assign you to this issue?

[Beamanator]

Marked NAB here but not in the deploy checklist, interesting 🧐 🤣 :paddlin:

[Kicu]

@luacmartins do I assume correctly that for now there is no work in the on front-end App side of things?

[luacmartins]

@shawnborton @JmillsExpensify could you confirm the behavior in this case? Should we open the transaction thread or expense report in this case? TLDR user has 2 expenses, leaves a comment on one of the threads and deletes that expense, effectively ending up with a single expense report.

[shawnborton]

Hmm I am a bit stumped on that one. Seems like it would make more sense to just open up the expense view, especially from the Expenses > All filter.

[luacmartins]

So open the expense report instead of the transaction thread?

[shawnborton]

Opposite - in that case, seems like opening the transaction view is better.

[luacmartins]

Hmm ok, so we'd need to change the backend logic a bit.

[luacmartins]

Cool, got a PR up to fix this one

[luacmartins]

This has been fixed!