Expense - Employee can edit paid expense but error shows up when advanced approvals is enabled

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.19-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/4847269
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Advanced approvals is enabled in the workspace via Workspace settings > Workflows > Add approval workflow > Upgrade.
• Admin and employee are in the same workspace.

1. Go to staging.new.expensify.com
2. [Employee] Submit an expense in the workspace chat.
3. [Admin] Approve and pay elsewhere the expense report.
4. [Employee] Go to the transaction thread of paid expense.
5. [Employee] Edit Description, Category, Tax etc.

Expected Result:

Since the transaction fields are enabled, employee should be able to edit the fields.

Or

The transaction fields should be disabled for employee.

Actual Result:

Employee has access to edit the paid expense but error shows up after saving the edit.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6570269_1723491413428.20240813_033015.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[AndrewGable]

Tagging the advanced approval experts if they have any ideas cc @tgolen @blazejkustra

[AndrewGable]

I do see a console error and am curious if this is causing issues?

[tgolen]

I would be pretty surprised if anything from the advanced approvals is causing that... but it's possible. Maybe @blazejkustra would know. Otherwise, I'd look for recent changes in OptionListUtils to see if you can spot something.

[Beamanator]

@youssef-lr or @cristipaval may know more about this since it seems related to https://github.com/Expensify/Expensify/issues/411546 or https://github.com/Expensify/Expensify/issues/411544 or https://github.com/Expensify/Expensify/issues/411545?

[youssef-lr]

@Beamanator I pinged you in the line from my PR causing this

[Beamanator]

sorry @youssef-lr can you also link that PR here?

[youssef-lr]

#46931

[youssef-lr]

also I think its fine to demote this. We don't have that many Control workspaces enabled for NewDot right now apart from our internal workspaces. The backend will still prevent us from editing.

[Beamanator]

That makes sense to me - if the backend is solid (which should mean OldDot works well) then lets call this NAB for now. Maybe you want to assign yourself for this fix?

[melvin-bot]

@youssef-lr, @CortneyOfstad Whoops! This issue is 2 days overdue. Let's get this updated quick!

[CortneyOfstad]

Not overdue!

[Beamanator]

#47398 was deployed to prod 2 days ago - @youssef-lr can we close this?