Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Remove acronym matching from Search #47237

Closed
mountiny opened this issue Aug 12, 2024 · 3 comments
Closed

[Performance] Remove acronym matching from Search #47237

mountiny opened this issue Aug 12, 2024 · 3 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Aug 12, 2024

Problem

We have implemented the search algorithm based on a library which also checked for acronyms. We have however noticed its not leading to different results in our implementation so the acronyms check is not useful at the moment (might change in future)

Solution

Lets remove it

Issue OwnerCurrent Issue Owner: @TMisiukiewicz
@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 12, 2024
@mountiny mountiny self-assigned this Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@TMisiukiewicz
Copy link
Contributor

Hi, I'm Tomasz from Callstack and I want to work on this issue

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 13, 2024
@mountiny
Copy link
Contributor Author

This is done now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2
Projects
Development

No branches or pull requests

3 participants