[Awaiting Payment 2024-09-19][$250] [HIGH] Invoicing V1 - Archive B2B invoice room when the receiver workspace is deleted

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.18-7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User A is an admin of his workspace
• User B is an admin of his workspace

1. Go to staging.new.expensify.com
2. [User A] Send an invoice to User B
3. [User B] Go to invoice chat
4. [User B] Click pay button > Pay the invoice as business > Pay elsewhere
5. [User B] Delete all the workspaces
6. [User A] Send another invoice
7. [User A] Click on the invoice preview

Expected Result:

Send invoice option should be hidden for User A because User B is no longer an admin of his workspace

Actual Result:

User A can still send invoice to User B after User B deletes all the workspaces, which results in error.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6566699_1723211569129.20240809_214105.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01903a726126738169
• Upwork Job ID: 1829110835274275153
• Last Price Increase: 2024-08-29

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[rlinoz]

@lanitochka17 do you have the prod behavior by any chance?

[rlinoz]

Hmmm did we just add the pay as business to invoices?

[rlinoz]

We added it here #44970, I think we should do something on the backend, let me check if we are already planning something.

[rlinoz]

There is a section for it in the doc, but I don't see an issue for it. Anyway I am removing the Web-E deploy blocker label then.

[rlinoz]

Asked in Slack https://expensify.slack.com/archives/CSL3XBCCR/p1723216392276109

[melvin-bot]

@cristipaval Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@cristipaval Huh... This is 4 days overdue. Who can take care of this?

[cristipaval]

Work in progress

[cristipaval]

Same, WIP.

[cristipaval]

So you need to:

1. Send an invoice to a user who is an admin of their primary workspace
2. Pay as business (so that the invoice room is upgraded to b2b)
3. Now the receiver deletes the workspace and the invoice room is archived
4. The sender now opens the invoice room (which is archived).
5. The App crashes

[rezkiy37]

So you need to:

1. Send an invoice to a user who is an admin of their primary workspace
2. Pay as business (so that the invoice room is upgraded to b2b)
3. Now the receiver deletes the workspace and the invoice room is archived
4. The sender now opens the invoice room (which is archived).
5. The App crashes

@cristipaval The staging does not crash for me, but I can send invoices to the archived invoice room. I will fix this because the app attaches the incorrect reportID.

Details

1.mp4

2.mp4

[jjcoffee]

Should we also fix the missing reportArchiveReasons.invoiceReceiverPolicyDeleted translation as part of this? It causes a crash on dev and an ugly string that displays in the archived room.

[rezkiy37]

@jjcoffee Yes, I am fixing it in the scope of the upcoming PR.

[rezkiy37]

Actively working on the issue.

[rezkiy37]

Discussing with @cristipaval in Slack.

[rezkiy37]

Hey!
I will be OOO from 04.09 (afternoon) till 09.09. I will continue to work on this one once I am back.

[isabelastisser]

Thanks for the update!

[rezkiy37]

Hey!
I've opened the PR (#48275) for review because the app's side is ready. One small backend improvement left. Discussion in Slack.

[jjcoffee]

@isabelastisser Looks like @cristipaval is on parental leave at the moment, is it possible to get another engineer assigned to review the PR?

[isabelastisser]

@rlinoz, any chance you can review the PR since Cristi is on leave? TIA!

[rlinoz]

Sure, on it.

[rlinoz]

This has been deployed to prod #48275 (comment)

[jjcoffee]

Since this is a CRITICAL feature for invoicing, I believe it also qualifies for $500 compensation, as on the other critical invoicing issues I worked on. cc @isabelastisser

[jjcoffee]

Regression Test Proposal

1. User A: Send an invoice to user B.
2. User B: Open the invoice and select to Pay as business. The invoice room will be upgraded to a B2B invoice room.
3. User B: Delete the workspace.
4. User A and User B: Open the invoice room and verify that the footer message is This chat is no longer active because ${policyName} is no longer an active workspace.
5. User A: Send another invoice to user B from the same workspace.
6. User A and user B: Verify that the app creates a new invoice room.

Do we agree 👍 or 👎

[isabelastisser]

Thanks, @jjcoffee! Offer sent in Upwork.

[isabelastisser]

All set!

[jjcoffee]

@isabelastisser Offer accepted, thanks!