[HOLD for payment 2024-08-19] [CRITICAL] [Advanced Approval Workflows] Implement Collect Upgrade Path

[tgolen]

cc @blazejkustra @Guccio163

Issue Owner

Current Issue Owner: @Guccio163

[Guccio163]

Hi, I'm Wiktor Gut from Software Mansion and I'm already working on this!

[garrettmknight]

👋 does this trigger off both 'Add additional approver' and 'Add additional workflow'?

[Guccio163]

Right now it is triggered only on Add approval workflow; The Add additional approver will be part of Editing and Creating workflow pages: it will be triggered only on Editing one, because the Adding page is already unavailable for users without Control plan.

On second thought, user can access Adding page directly via typing url by hand, but I guess guys from backend also check if user is authorised to do the action, do I think right @tgolen @blazejkustra ?

[garrettmknight]

it will be triggered only on Editing one

I think Collect users will still see the Add additional approver option when editing their single workflow right?

[Guccio163]

Yup, afaik every user will be able to open Edit workflow page and it will look exactly the same for everyone, only difference is that Collect users will be able to actually add additional approver after clicking Add additional approver button and non-Collect users will be redirected to the Upgrade page

[garrettmknight]

Yup, afaik every user will be able to open Edit workflow page and it will look exactly the same for everyone, only difference is that Collect users will be able to actually add additional approver after clicking Add additional approver button and non-Collect users will be redirected to the Upgrade page

*Control, but yep! So we'll want to add the Upgrade flow for:

1. Collect users that click 'Add additional approver' in the workflow edit screen
2. Collect users that click 'Add additional workflow' in the workflow menu.

[Guccio163]

Exactly! It is already working for Add additional workflow in menu and will be implemented for Add additional approver in workflow edit screen once this screen's made.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Upgrade advanced approvals #46808

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

• @Guccio163 does not require payment (Contractor)

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[s77rt]

@tgolen Can you please assign me here for PR review

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[tgolen]

@lschurr Could you please assist with paying @s77rt for a C+ review of the PR?

[lschurr]

Yep! It looks like @s77rt is paid via NewDot, so we'll just need the payment summary here.

Payment summary:

• Contributor: @Guccio163 (No payment needed - Contractor)
• Reviewer: @s77rt $250 (Please request via NewDot)

[JmillsExpensify]

$250 approved for @s77rt