-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for Payment 2024-08-22][$250] Multi tag - Selection mode remains on main tag list after returning from sub tag list #46658
Comments
Triggered auto assignment to @RachCHopkins ( |
Triggered auto assignment to @carlosmiceli ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think this issue might be related to the #collect project. |
I think the issue comes from here: #46096 @jasperhuangg is this a deploy blocker? Because what I'm seeing is that it's all new functionality, right? Wanna decide what we do here? |
@carlosmiceli Yeah this doesn't need to be a blocker. It's just a minor display bug that doesn't prevent you from using the app, and this feature doesn't yet exist on production. |
Job added to Upwork: https://www.upwork.com/jobs/~013892471bd59b7984 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 ( |
Hi! I am Filip from SWM and I'd like to take this as it comes from my PR |
PR review being handled by @ikevin127 as regression from a previous PR #46698 (comment) |
cc @RachCHopkins for payments |
@carlosmiceli it's not clear to me here who needs to be paid, would you mind giving me a wee summary of who did what? |
I think the PR is authored by @filip-solecki and was reviewed by @ikevin127, correct? |
✅ Correct, I'm the only one requiring payment here. |
@ikevin127 I have sent you an offer for the job! |
@RachCHopkins Offer accepted, thanks! |
Payment Summary: Contributor+: @ikevin127 paid $250 via Upwork |
Contributor has been paid, the contract has been completed, and the Upwork post has been closed. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.15-4
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition:
Expected Result:
Selection mode will be dismissed on the main tag list because main tag cannot be selected for multi tags.
Actual Result:
Selection mode remains on main tag list after returning from sub tag list.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6559036_1722505630936.ScreenRecording_08-01-2024_17-40-50_1.1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ishpaul777The text was updated successfully, but these errors were encountered: