Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRITICAL] [Advanced Approval Workflows] Implement <WorkspaceWorkflowsApprovalsEditPage /> for Editing Workflow #45953

Closed
tgolen opened this issue Jul 22, 2024 · 19 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review Task

Comments

@tgolen
Copy link
Contributor

tgolen commented Jul 22, 2024

Coming from: #wave-control: advanced approval + workflows polish

Issue OwnerCurrent Issue Owner: @isabelastisser
@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

Copy link

melvin-bot bot commented Jul 26, 2024

@tgolen, @blazejkustra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jul 26, 2024
Copy link

melvin-bot bot commented Jul 30, 2024

@tgolen, @blazejkustra 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Aug 1, 2024

@tgolen, @blazejkustra Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Copy link

melvin-bot bot commented Aug 5, 2024

@tgolen, @blazejkustra 12 days overdue. Walking. Toward. The. Light...

@melvin-bot melvin-bot bot removed the Daily KSv2 label Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

This issue has not been updated in over 14 days. @tgolen, @blazejkustra eroding to Weekly issue.

@blazejkustra
Copy link
Contributor

@MelvinBot Calm down, I'm working on a PR 🙈

@DylanDylann
Copy link
Contributor

I'm glad to be assigned to this issue; I have context regarding the approval flow in this PR

@DylanDylann
Copy link
Contributor

@tgolen Could you help process payment for me to review this PR?

@tgolen tgolen added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 21, 2024
Copy link

melvin-bot bot commented Aug 21, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 21, 2024
@tgolen
Copy link
Contributor Author

tgolen commented Aug 21, 2024

@isabelastisser Could you please help with paying @DylanDylann for a C+ review of the PR?

@isabelastisser
Copy link
Contributor

@DylanDylann, the offer was sent in Upwork. Please accept it, and I will process the payment. Thanks!

@isabelastisser
Copy link
Contributor

wait, not sure if this should've been closed.

@dylmye
Copy link
Contributor

dylmye commented Aug 21, 2024

@DylanDylann, the offer was sent in Upwork. Please accept it, and I will process the payment. Thanks!

Hi I believe you sent this to me as I just received an Upwork email for you - just wanted to confirm I am not the individual you meant to send this to :)

Copy link

melvin-bot bot commented Aug 21, 2024

📣 @dylmye! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@isabelastisser
Copy link
Contributor

ops, thanks for the heads up @dylmye!

@DylanDylann, what's your Upwork profile?

@DylanDylann
Copy link
Contributor

@isabelastisser Here it is https://www.upwork.com/freelancers/~010c6310ab55f3d17d

@tgolen
Copy link
Contributor Author

tgolen commented Aug 30, 2024

@isabelastisser do you need anything else here or can this be paid and closed out?

@isabelastisser
Copy link
Contributor

This has been paid already. All set, Tim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review Task
Projects
None yet
Development

No branches or pull requests

5 participants