Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Details revamp] No option to cancel payment for paid expense as 3-dot menu is removed #45077

Closed
6 tasks done
lanitochka17 opened this issue Jul 9, 2024 · 14 comments
Closed
6 tasks done
Assignees
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.5-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Admin and employee are in the same workspace
  • Workspace is connected to bank account
  • Employee has personal bank account
  1. Go to staging.new.expensify.com
  2. [Employee] Go to workspace chat and submit an expense
  3. [Admin] Go to the expense report from employee
  4. [Admin] Pay the expense with Expensify
  5. [Admin] On expense report, click on the report header

Expected Result:

There should be an option to cancel payment. On prod, cancel payment option is accessible from 3-dot menu

Actual Result:

There is no option to cancel payment for paid expense as 3-dot menu is removed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6536793_1720525601263.20240709_194230.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 9, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Jul 9, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@Gonals FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@cdOut
Copy link
Contributor

cdOut commented Jul 9, 2024

This was caused by the PR I worked on from the Details Revamp that removed the 3-dot menu, it must've been something that we overlooked while testing during the removal. I will create a PR that re-adds this feature into the Details page.

@parasharrajat
Copy link
Member

parasharrajat commented Jul 9, 2024

To clarify, I thought that we already added these buttons in some PR before working on 3-dot menu removal PR and that PR was only to remove the menu. Is it correct @cdOut?

@cdOut
Copy link
Contributor

cdOut commented Jul 9, 2024

@parasharrajat I've looked back and no, this button was never considered in the design doc nor was it included anywhere in the issue descriptions / discussion threads that we did. We have added others for deleting, booking a call etc. but this one was missed during considerations.

@cdOut
Copy link
Contributor

cdOut commented Jul 9, 2024

I'll focus on getting a PR up for this one as soon as possible.

@mountiny mountiny removed the DeployBlocker Indicates it should block deploying the API label Jul 9, 2024
@Gonals
Copy link
Contributor

Gonals commented Jul 9, 2024

@cdOut, how is this going?

@cdOut
Copy link
Contributor

cdOut commented Jul 9, 2024

@Gonals I've created a PR for it and moved it to review.

@mountiny
Copy link
Contributor

#45130 (comment) QA worked well in staging

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Jul 10, 2024
@trjExpensify trjExpensify changed the title Expense - No option to cancel payment for paid expense as 3-dot menu is removed [Details revamp] No option to cancel payment for paid expense as 3-dot menu is removed Jul 15, 2024
@cdOut
Copy link
Contributor

cdOut commented Jul 29, 2024

Can we close out this issue as the PR for it has been merged?

@trjExpensify
Copy link
Contributor

Payment summary as follows:

Feel free to request, closing!

@JmillsExpensify
Copy link

$250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
Archived in project
Development

No branches or pull requests

8 participants