Report fields - Blank list is shown briefly after deleting all report fields

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Go to Report fields (enable in More features if not yet)
4. Add a report field
5. Click on the report field
6. Click Delete
7. Delete the report field

Expected Result:

The report field page will show the empty state screen immediately (like it does on Categories and Tags page)

Actual Result:

The report field shows blank first briefly before showing empty state screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6535972_1720449739031.20240708_223735.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@francoisl FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report fields - Blank list is shown briefly after deleting all report fields

What is the root cause of that problem?

We aren't checking for pending state like we do in tags and category page.

What changes do you think we should make in order to solve the problem?

Add similar check in WorkspaceReportFieldsPage.

const hasVisibleTag = Object.values(filteredPolicyFieldList).some((tag) => tag.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || isOffline);

What alternative solutions did you explore? (Optional)

[francoisl]

This is probably from #44493, not going to block on this as it's not breaking anything.

[mountiny]

Going to handle this with @rezkiy37 and @waterim as we are working on the project

[melvin-bot]

Current assignee @mountiny is eligible for the DeployBlockerCash assigner, not assigning anyone new.

[mountiny]

The report fields is behind beta still

[waterim]

Hello, Im Artem and would like to help with this issue!
This issue will be fixed here

[rushatgabhane]

PR reviewed and merged