Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Delay in showing LHN and not found page in report screen when switching between bottom tabs #44949

Closed
1 of 6 tasks
mountiny opened this issue Jul 8, 2024 · 11 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@mountiny
Copy link
Contributor

mountiny commented Jul 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

Break down in numbered steps

  1. Log into a heavy account
  2. Switch from Chats to Settings
  3. Switch back to Chats
  4. Repeat

Expected Result:

Describe what you think should've happened

There should be little to no delay when rendering the individual pages

Actual Result:

Describe what actually happened

Seems like there are some extra renders or we are waiting longer for rendering something

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Staging:

Screen.Recording.2024-07-08.at.10.52.47.mov

Production:

Screen.Recording.2024-07-08.at.10.57.32.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e0321979061e3e17
  • Upwork Job ID: 1810252490706554621
  • Last Price Increase: 2024-07-08
Issue OwnerCurrent Issue Owner: @ishpaul777
@mountiny mountiny added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 8, 2024
@mountiny mountiny self-assigned this Jul 8, 2024
@melvin-bot melvin-bot bot changed the title Delay in showing LHN and not found page in report screen when switching between bottom tabs [$250] Delay in showing LHN and not found page in report screen when switching between bottom tabs Jul 8, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01e0321979061e3e17

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 8, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

Current assignee @mountiny is eligible for the DeployBlockerCash assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Jul 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

Copy link

melvin-bot bot commented Jul 8, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Julesssss
Copy link
Contributor

Julesssss commented Jul 8, 2024

After catching up on the discussion here, I lean towards not blocking on this.

For now we will continue, but if this ends up being the last blocker I will continue. It is a worse experience for large accounts, but not a huge deal IMO. But @mountiny, feel free to make a counterargument if I missed the context.

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Jul 8, 2024
@mountiny
Copy link
Contributor Author

mountiny commented Jul 8, 2024

I agree, seems like they did not find anything that would make the staging noticeably slower than production, it might have been caused by something else for me. There are already some PRs that should improve this

@ishpaul777
Copy link
Contributor

Awaiting proposals

@mountiny
Copy link
Contributor Author

At this point, I am not sure if I am able to reproduce, have you been able to notice anything like this @ishpaul777 ?

@ishpaul777
Copy link
Contributor

Not reproducable 🎉

Screen.Recording.2024-07-11.at.8.18.22.PM.mov

@isabelastisser
Copy link
Contributor

Thanks, team! Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

4 participants