[HOLD for payment 2024-07-22] [$50] Report fields - Initial value in the system message is defined as "undefined"

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Report fields.
3. Create a List type report field, add a few list values and select an initial value (important).
4. Go to workspace chat.
5. Submit two expenses.
6. Go to expense report.
7. Click on the List report field created in Step 3.
8. Select other item other than the initial value.
9. Revisit the expense report.

Expected Result:

The system message for the initial value should be defined properly.

Actual Result:

The system message for the initial value is "undefined" - "change field from undefined to X".

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6533432_1720123862750.20240705_040521.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014ad96192c5fd527a
• Upwork Job ID: 1809157004996923791
• Last Price Increase: 2024-07-22

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

I can take this over and look into it with the project team

@waterim @rezkiy37 @shubham1206agra @rushatgabhane

[mountiny]

Not a blocker because this is behind beta

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014ad96192c5fd527a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[izarutskaya]

We think this issue might be related to the #vip-vsb

[nkdengineer]

@mountiny Is this external for contributor or the project team will take care this issue?

[mountiny]

@nkdengineer Lets do external for this one

[mountiny]

@nkdengineer lets go with your proposal to make sure we treat the oldValue as empty when undefined

[nkdengineer]

@mountiny Do I need to create a PR here?

[mountiny]

@nkdengineer I have confirmed what I wanted to check. I'm not sure what was going on, but yesterday, all your posts disappeared; I went ahead and created the quick PR. We would pay you $50 for your help

[nkdengineer]

Thanks. I don't know what the problem is, but on my side everything is good and it's too late in my timezone at the time you assigned to me.

[mountiny]

I know, but your gh profile was showing 404 not found and all your comments diseappeared :D github was doing april fools, I guess

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Correctly return early for CHANGEFIELD #44944

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @shubham1206agra requires payment (Needs manual offer from BZ)
• @nkdengineer requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane / @shubham1206agra] Determine if we should create a regression test for this bug.
• [@rushatgabhane / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @rushatgabhane owed $250 via NewDot
• ROLE: @shubham1206agra paid $(AMOUNT) via Upwork (LINK)
• ROLE: @nkdengineer paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@sakluger)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1809157004996923791/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Upwork job price has been updated to $50

[mountiny]

This is ready for payment, $50 to @nkdengineer

[sakluger]

@nkdengineer I sent you an offer via Upwork: https://www.upwork.com/nx/wm/offer/103223949/

Please let me know once you've accepted it. Thanks!

[nkdengineer]

@sakluger I accepted it thanks

[sakluger]

Thanks! All paid 👍