-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-07-17] Categories - The subtitle under "Members must categorize all expenses" contains "undefined" #44826
Comments
Triggered auto assignment to @srikarparsi ( |
Triggered auto assignment to @zanyrenney ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Categories - The subtitle under "Members must categorize all expenses" contains "undefined" What is the root cause of that problem?Undefined is shown when current policy does not have any connection.
What changes do you think we should make in order to solve the problem?Show a different subtitle when policy does not have any connection. We can create one or use What alternative solutions did you explore? (Optional) |
@Krishna2323 I think we should use |
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf ( |
@tgolen, |
This is a deploy blocker, what is the offending PR @Krishna2323 ? |
Perfect, this is fine. Thanks! I'll assign you |
ummm, I agree with @Krishna2323, we should not show any subtitle if we do not have any connection, @tgolen what do you think ? |
This was CPed and the PR is pending validation in staging |
@mountiny can you update the title to hold for payment please |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-17. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-22. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Regression Test Proposal
Do we agree 👍 or 👎 |
Note @zanyrenney , this is ready for payment, the payment date is wrong, idk why melvin is acting so weird lately, so the payment date was actually 15th, can you pay this out please, thanks |
okay thanks @allgandalf |
@allgandalf @Krishna2323 please accept job offer via upwork! |
Applied from my side 👍 |
payment summary @Krishna2323 requires payment (Needs manual offer from BZ) - paid $250 via Upwork |
payments complete, and regression test requested! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.4-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
The subtitle under "Members must categorize all expenses" will not contain "undefined".
Actual Result:
The subtitle under "Members must categorize all expenses" contains "undefined".
"Require a category on every expense in order to export to undefined."
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6533029_1720092955253.bandicam_2024-07-04_19-34-38-797.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @zanyrenneyThe text was updated successfully, but these errors were encountered: