[HOLD for payment 2024-07-22] [$250] Invoice - App crashes after receiver deletes all workspaces and sender is unable to send invoice

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #43036
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User A and User B have their own workspace.

1. Go to staging.new.expensify.com
2. [User A] Send an invoice to User B.
3. [User B] Go to invoice chat.
4. [User B] Click pay button > Pay the invoice as business > Pay elsewhere.
5. [User A] Send another invoice.
6. [User A] Note that User A can send another invoice.
7. [User B] Delete all the workspaces.
8. [User B] Note that app crashes after deleting the workspace.
9. [User A] Send another invoice to User B in the same workspace chat.
10. [User A] Note that user cannot send invoice after User B deletes all the workspaces.
11. [User B] Go to Account settings > Workspaces.
12. [User B] Note that the workspace list shows blank workspace under Free plan.

Expected Result:

In Step 8, app will not crash after user B deletes all the workspaces.
In Step 10, User A should be able to send another invoice to User B after user B deletes all the workspaces.
In Step 12, there should not be any workspace in the list.

Actual Result:

In Step 8, app crashes after user B deletes all the workspaces.
In Step 10, User A is unable to send another invoice to User B after user B deletes all the workspaces.
In Step 12, there is a blank workspace under Free plan.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6532944_1720087574886.bandicam_2024-07-04_17-59-00-716.mp4

Bug6532944_1720087574902!staging.new.expensify.com-1720087225348.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015e8883cec9f5dd20
• Upwork Job ID: 1808990503832944883
• Last Price Increase: 2024-07-04
• Automatic offers:
• c3024 | Contributor | 103001035

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@muttmuure I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project. #vip-bills

[carlosmiceli]

Can't reproduce.

[lanitochka17]

Issue is still reproducible

20240705_031113.mp4

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @carlosmiceli is eligible for the DeployBlockerCash assigner, not assigning anyone new.

[carlosmiceli]

@lanitochka17 @izarutskaya To clarify, "User A and User B have their own workspace." means that they both belong to a workspace that was created by User B, right?

[luacmartins]

@carlosmiceli I think that means that user A is the owner of workspace A and user B is the owner of workspace B

[carlosmiceli]

That explains a lot 😅

[carlosmiceli]

This is looking like the offender: #43036

cc @cristipaval @VickyStash can you see if you can find a fix? Adding External for more proposals in the meantime.

[VickyStash]

I was able to reproduce the issue, though there was no crash or blank workspace for me.

@cristipaval There are something that I've noticed that can be useful:

1. After the receiver workspace is removed, invoiceReceiver turns into null
   

2. During OpenReport a policy with an empty avatar and name is loaded
   

3. Sending invoice doesn't work cause invoiceReceiver is null I guess, it returns this error:
   
   Overall it looks like the room should be archived.

[cristipaval]

Thanks a lot! That is valuable information. I'll jump into investigating on the backend side.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Add Pay as Business option for invoices sent to an individual who is admin of their primary workspace" #44891

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[cristipaval]

We will need to pay $250 to @c3024 for their help and review

@muttmuure this is the only payment due. The crash is still under investigation.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Add Pay as Business option for invoices sent to an individual who is admin of their primary workspace" #44891

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[carlosmiceli]

@c3024 small bump :)

[c3024]

• [@c3024] The PR that introduced the bug has been identified. Link to the PR: This is a revert PR for Add Pay as Business option for invoices sent to an individual who is admin of their primary workspace #43036. The authors are aware that the PR was reverted.
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No, this is not a bug that could be identified earlier with any steps.
• [@c3024] Determine if we should create a regression test for this bug. This was identified during staging regression tests. So, no regression test is required.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. NA

[muttmuure]

Paid