Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick and Version bump PRs are showing up in Deploy Checklist #4462

Closed
Jag96 opened this issue Aug 6, 2021 · 1 comment
Closed

Cherry Pick and Version bump PRs are showing up in Deploy Checklist #4462

Jag96 opened this issue Aug 6, 2021 · 1 comment
Assignees
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@Jag96
Copy link
Contributor

Jag96 commented Aug 6, 2021

Problem

When a PR is cherry-picked to staging, the automerge PR made to CP the PR to staging is included in the Deploy Checklist (example). Then, when the version is bumped, the automerge PR to bump the version is added to the checklist as well, adding unnecessary noise for QA.

Solution

Don't add PRs with the automerge label to the Checklist:

cc @AndrewGable @roryabraham

@Jag96 Jag96 added Engineering Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff labels Aug 6, 2021
@Jag96 Jag96 self-assigned this Aug 6, 2021
@roryabraham
Copy link
Contributor

As discussed here, this should hopefully be fixed in #4408

@Jag96 Jag96 added the Reviewing Has a PR in review label Aug 9, 2021
@Jag96 Jag96 closed this as completed Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants