Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to open a single expense report as approver #44411

Closed
1 of 6 tasks
m-natarajan opened this issue Jun 25, 2024 · 19 comments
Closed
1 of 6 tasks

Unable to open a single expense report as approver #44411

m-natarajan opened this issue Jun 25, 2024 · 19 comments
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Needs Reproduction Reproducible steps needed Reviewing Has a PR in review

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1718982172128879

Action Performed:

  1. Submit a single expense report in a workspace chat
  2. As approver open the report

Expected Result:

Report opened without any issue

Actual Result:

Unable to open the report and Loading skeleton displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jun 25, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Copy link

melvin-bot bot commented Jun 25, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@puneetlath puneetlath added the AutoAssignerNewDotQuality Used to assign quality issues to engineers label Jun 25, 2024
Copy link

melvin-bot bot commented Jun 25, 2024

Triggered auto assignment to @NikkiWines (AutoAssignerNewDotQuality)

@melvin-bot melvin-bot bot added the Weekly KSv2 label Jun 25, 2024
@NikkiWines
Copy link
Contributor

Hmm, I'm not able to reproduce this issue on staging currently. @puneetlath can you confirm if this is still an issue for you?

Screen.Recording.2024-06-26.at.23.28.47.mov

@NikkiWines
Copy link
Contributor

Reached out to @puneetlath about this today - there's an ongoing investigation into the bug here. Will follow up with this starting next week 🙇

@melvin-bot melvin-bot bot added the Overdue label Jul 1, 2024
@NikkiWines NikkiWines removed the Daily KSv2 label Jul 1, 2024
@NikkiWines
Copy link
Contributor

Investigation is ongoing

@melvin-bot melvin-bot bot removed the Overdue label Jul 2, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

@NikkiWines @muttmuure this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@NikkiWines
Copy link
Contributor

Investigation is still ongoing

@kevinksullivan
Copy link
Contributor

@NikkiWines @muttmuure if this is a CRITICAL item it should be daily, right? I'll update, but lmk if I am missing something!

@kevinksullivan kevinksullivan added Daily KSv2 and removed Weekly KSv2 labels Jul 10, 2024
@muttmuure
Copy link
Contributor

muttmuure commented Jul 11, 2024

I was expecting this to be fixed by better gap detection which merged this week - is this definitely still happening?

@muttmuure
Copy link
Contributor

@puneetlath do you mind testing this again?

@muttmuure
Copy link
Contributor

muttmuure commented Jul 11, 2024

This hit staging 3 days ago, and production yesterday: #41962

@puneetlath
Copy link
Contributor

Still having the problem. We've narrowed it down to a problem when a personal card transaction gets merged with a receipt. @NikkiWines is working on the fix.

@melvin-bot melvin-bot bot added the Overdue label Jul 15, 2024
@NikkiWines
Copy link
Contributor

Getting tests working for this now, hoping to have a PR up by EOD

@melvin-bot melvin-bot bot removed the Overdue label Jul 15, 2024
@NikkiWines
Copy link
Contributor

Hmm, actually what I had wasn't working, pivoting to another solution where we update the IOU reportAction after merging

@NikkiWines NikkiWines added Reviewing Has a PR in review Engineering Improvement Item broken or needs improvement. labels Jul 17, 2024
Copy link

melvin-bot bot commented Jul 24, 2024

@puneetlath, @NikkiWines, @muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@puneetlath
Copy link
Contributor

This is done and deployed. Just need someone to confirm it's working properly when using this out in the wild.

Copy link

melvin-bot bot commented Aug 1, 2024

@puneetlath, @NikkiWines, @muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@puneetlath
Copy link
Contributor

This works. Going to go ahead and close it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Needs Reproduction Reproducible steps needed Reviewing Has a PR in review
Projects
Development

No branches or pull requests

6 participants