Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Workspace Feeds] [External] Logic for saving the data and navigating between steps #44308

Closed
mountiny opened this issue Jun 24, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2

Comments

@mountiny
Copy link
Contributor

Part of the Workspace feeds project.

Implement the following part of the design doc.

@koko57 @VickyStash @allgandalf @DylanDylann

@koko57
Copy link
Contributor

koko57 commented Jun 25, 2024

taking this issue 🙂

@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Jun 25, 2024
@koko57 koko57 mentioned this issue Jun 25, 2024
61 tasks
@koko57
Copy link
Contributor

koko57 commented Jun 25, 2024

@mountiny I've opened a draft PR. I've marked this one No QA, bc I think that it doesn't make sense to QA test the flow's skeleton. Let me know if it's ok

@DylanDylann
Copy link
Contributor

I will take this one

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jun 25, 2024
@koko57
Copy link
Contributor

koko57 commented Jun 25, 2024

@DylanDylann @mountiny PR ready for review

@DylanDylann
Copy link
Contributor

DylanDylann commented Jun 25, 2024

@koko57 I just glanced at the design doc for this project. Why do we start this project at this issue? Should we implement these features followed by the order in the design doc? I think It will be easy to test and control the process of this project

cc @MariaHCD @mountiny @allgandalf @VickyStash

@koko57
Copy link
Contributor

koko57 commented Jun 25, 2024

@DylanDylann some of the features can be done in parallel to speed up the process. I don't think we need to implement these features one after another. Of course, some features like Card Settings, Reconciliation and Card Details will be done later, after some other will be finished.

@mountiny
Copy link
Contributor Author

I agree, we still need to work on the backend so at this point we are focusing on creating the frontend flows and getting as much of the UI done as possible so we are in a good spot once we get the backend into a ready state

@trjExpensify
Copy link
Contributor

Did this issue get covered by this PR #44376?

@koko57
Copy link
Contributor

koko57 commented Jul 1, 2024

@trjExpensify yes

@allgandalf allgandalf removed their assignment Jul 8, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 10, 2024
@melvin-bot melvin-bot bot changed the title [Workspace Feeds] [External] Logic for saving the data and navigating between steps [HOLD for payment 2024-07-17] [Workspace Feeds] [External] Logic for saving the data and navigating between steps Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

  • @koko57 does not require payment (Contractor)
  • @DylanDylann requires payment (Needs manual offer from BZ)

@koko57
Copy link
Contributor

koko57 commented Jul 10, 2024

@mountiny we can close this. There will be no follow-up PR for this one.

@mountiny
Copy link
Contributor Author

Ok thank you!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-17] [Workspace Feeds] [External] Logic for saving the data and navigating between steps [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Workspace Feeds] [External] Logic for saving the data and navigating between steps Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

  • @koko57 does not require payment (Contractor)
  • @DylanDylann requires payment (Needs manual offer from BZ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2
Projects
Archived in project
Development

No branches or pull requests

6 participants