[HOLD] Manually CPing a pull request does not add the PR to the checklist

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Lock the deploy checklist
2. Merge a PR.
3. Manually cherry-pick the PR.

Expected Result:

The deploy checklist should be updated with the new PR.

Actual Result:

The deploy checklist is not updated.

Workaround:

N/A

Platform:

GitHub only

Version Number: 1.0.82-2

View all open jobs on Upwork

[roryabraham]

No update here, but it would be a great FP for someone looking to familiarize themselves with the NewDot deploy code. Feel free to snag this from me if you're interested!

[roryabraham]

Sorry, no update again.

[roryabraham]

PR is up

[botify]

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[roryabraham]

I had to revert the PR to fix this, so I'm reopening it.

[roryabraham]

Just realized that, while I fixed the bigger related bug, I never actually came back to fix this one. Should be a pretty quick-and-easy fix.

[roryabraham]

New PR is up

[roryabraham]

Had to revert the solution again 😞

[roryabraham]

Going to work on figuring out #4977 first

[roryabraham]

Some additional context in this slack thread but the solution for this issue would likely also solve #6863.

TL;DR we want to make sure that the CP PR is merged and the tag for the new version is pushed before updating the checklist.

[roryabraham]

Hopefully got a solution up for #4977, so this issue is next.

[roryabraham]

Also related: #7178

[roryabraham]

Note to self, the comments from #7802 also won't work with a manual CP

[roryabraham]

No update on deploy stuff rn. I created a tracking issue here

[roryabraham]

on HOLD

[Beamanator]

FYI in this checklist, it looks like OSBotify did add 2 [CP Staging] PRs to the checklist, but we had more than 2 CP'd PRs yesterday 😅

PRs that got added to checklist:

• [CP Staging] Return early when dismissing modal so we don't call onNavigate with no attachments #23988
• [CP Staging] [Revert] Perf/onyx upgrade use cache directly #24003

PRs that got CP'd yesterday:

• [CP Staging] Return early when dismissing modal so we don't call onNavigate with no attachments #23988
• [CP Staging] [Revert] Perf/onyx upgrade use cache directly #24003
• Revert "fix: show main composer when there is no focused draft" #24025
• [CP Staging] Remove reference to missing method #24010

[roryabraham]

Actually going to close this as a dupe of #21763 because that has better bread crumbs at this point