Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-28] [Free trial] Implement all Free Trials utility functions #43668

Closed
MitchExpensify opened this issue Jun 13, 2024 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@MitchExpensify MitchExpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MitchExpensify
Copy link
Contributor Author

cc @fabioh8010 @pac-guerreiro as you'll be picking this up

@fabioh8010
Copy link
Contributor

Hi, I'm Fábio - expert agency contributor - and I would like to work on this issue.

@MitchExpensify MitchExpensify added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Current assignee @bfitzexpensify is eligible for the NewFeature assigner, not assigning anyone new.

@fabioh8010
Copy link
Contributor

PR is up -> #43844

@hoangzinh
Copy link
Contributor

@MitchExpensify The util ReportUtils.getChatUserForOnboarding() in PR description probably has a typo, it should be ReportUtils.getChatUsedForOnboarding() according to PR https://github.com/Expensify/App/pull/43844/files#diff-577fcc5f3a5e4930916ff310e61c38edfa093792fe3ab55b9a30d2aecd8811dbR6987

cc @fabioh8010 for confirming.

@fabioh8010
Copy link
Contributor

@hoangzinh That is correct, should be ReportUtils.getChatUsedForOnboarding()

@trjExpensify trjExpensify added Daily KSv2 and removed Weekly KSv2 labels Jun 18, 2024
@trjExpensify
Copy link
Contributor

This is a top priority for the Summer release, putting the issue on Daily.

@trjExpensify
Copy link
Contributor

Deployed to staging, nice!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Jun 21, 2024
@melvin-bot melvin-bot bot changed the title [Free trial] Implement all Free Trials utility functions [HOLD for payment 2024-06-28] [Free trial] Implement all Free Trials utility functions Jun 21, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 21, 2024
Copy link

melvin-bot bot commented Jun 21, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jun 21, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

  • @rojiphil requires payment (Needs manual offer from BZ)
  • @hoangzinh requires payment (Needs manual offer from BZ)
  • @fabioh8010 does not require payment (Contractor)

Copy link

melvin-bot bot commented Jun 21, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rojiphil / @hoangzinh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@bfitzexpensify bfitzexpensify added Daily KSv2 and removed Weekly KSv2 labels Jun 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 25, 2024
@bfitzexpensify
Copy link
Contributor

Switching this to daily to action on Friday

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 25, 2024
@bfitzexpensify
Copy link
Contributor

Offers sent @hoangzinh @rojiphil

@melvin-bot melvin-bot bot removed the Overdue label Jun 28, 2024
@hoangzinh
Copy link
Contributor

Accepted. Thanks @bfitzexpensify

@bfitzexpensify
Copy link
Contributor

Thanks for the quick action - payments all complete, closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

7 participants