Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QBO - Location switch button hint text is not as expected #43119

Closed
6 tasks done
m-natarajan opened this issue Jun 5, 2024 · 7 comments
Closed
6 tasks done

QBO - Location switch button hint text is not as expected #43119

m-natarajan opened this issue Jun 5, 2024 · 7 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering

Comments

@m-natarajan
Copy link

m-natarajan commented Jun 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when verifying #41638
Version Number: 1.4.79-6
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Create a new workspace
  2. Go to the More Feature page and enable the accounting feature
  3. Connect to QBO
  4. Go to the Export page. Check that Vendor Bill is selected for Export out-of-pocket expenses as by default
  5. Go to the Import page. Check the Location configuration. Check that the Switch is toggled off and locked.

Expected Result:

There should be a hint text under the Switch button. Use the screenshot attached as a reference.

Actual Result:

A hint text under the Switch button is different (screenshot attached)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Expected text hint

Bug6502548_1717580957810!expected

Actual text hint
Bug6502548_1717580957811!actual

Bug6502548_1717580957798.hint_for_accounting.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @hayata-suenaga
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jun 5, 2024
Copy link

melvin-bot bot commented Jun 5, 2024

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jun 5, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@dragnoir
Copy link
Contributor

dragnoir commented Jun 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

QBO wrong description

What is the root cause of that problem?

Wrong text for the description used on QBO Locations page

locationsAdditionalDescription: `QuickBooks Online does not support adding a location to vendor bills or checks. Update your export preference to journal entry if you'd like to import locations as tags.`,

What changes do you think we should make in order to solve the problem?

Set the new text here

locationsAdditionalDescription: `QuickBooks Online does not support adding a location to vendor bills or checks. Update your export preference to journal entry if you'd like to import locations as tags.`,

and update the spanish language

What alternative solutions did you explore?

@bondydaa
Copy link
Contributor

bondydaa commented Jun 5, 2024

I don't think this is a blocker, the copy was changed here bcecada

cc @hayata-suenaga can you confirm. We probably just need to update the QA test steps with the latest copy.

@bondydaa bondydaa assigned hayata-suenaga and unassigned bondydaa Jun 5, 2024
@bondydaa bondydaa removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jun 5, 2024
@trjExpensify
Copy link
Contributor

Yep, this was an intentional change. I'd close this issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering
Projects
None yet
Development

No branches or pull requests

6 participants