Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-13] [MEDIUM] Add "Schedule a demo" link to the Travel landing page #42776

Closed
bfitzexpensify opened this issue May 29, 2024 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design NewFeature Something to build that is a new item.

Comments

@bfitzexpensify
Copy link
Contributor

bfitzexpensify commented May 29, 2024

We need to add a Schedule a demo link to the Travel landing page:

image

This is how it should look:

image

I think this is where the code lives, but I am not 100% certain.

Issue OwnerCurrent Issue Owner: @twisterdotcom
@twisterdotcom twisterdotcom self-assigned this May 29, 2024
@twisterdotcom twisterdotcom added the NewFeature Something to build that is a new item. label May 29, 2024
Copy link

melvin-bot bot commented May 29, 2024

Current assignee @twisterdotcom is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Weekly KSv2 label May 29, 2024
@twisterdotcom
Copy link
Contributor

@rushatgabhane or @smelaa - would you like to take this one?

@twisterdotcom twisterdotcom changed the title [MEDIUM] [VIP-Travel] Add Schedule a demo link to the Travel landing page [MEDIUM] Add Schedule a demo link to the Travel landing page May 29, 2024
@rushatgabhane
Copy link
Member

@twisterdotcom i can pick this

@twisterdotcom
Copy link
Contributor

Assigning @shubham1206agra to review too then.

Copy link

melvin-bot bot commented May 30, 2024

Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

@dannymcclain
Copy link
Contributor

I tossed the design label on here just to get eyes on the implementation. @dubielzyk-expensify nothing too wild going on here from a design standpoint, just want to make sure that button stack looks right. Feel free to reassign to me if ya wanna.

@rushatgabhane
Copy link
Member

rushatgabhane commented May 30, 2024

@dannymcclain is there a figma link? i need to know the value of spacing between the buttons.

edit: found it here https://www.figma.com/design/rOyUSHbLLyp64emz6WeoPW/Travel?node-id=892-7795&t=5nZ2ixVrRKaCQd8s-0

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 30, 2024
@rushatgabhane
Copy link
Member

PR ready here - #42864

Copy link

melvin-bot bot commented Jun 2, 2024

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@dubielzyk-expensify
Copy link
Contributor

Approved the PR 👍 Looking good

@twisterdotcom twisterdotcom changed the title [MEDIUM] Add Schedule a demo link to the Travel landing page [MEDIUM] Add "Schedule a demo" link to the Travel landing page Jun 3, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 6, 2024
@melvin-bot melvin-bot bot changed the title [MEDIUM] Add "Schedule a demo" link to the Travel landing page [HOLD for payment 2024-06-13] [MEDIUM] Add "Schedule a demo" link to the Travel landing page Jun 6, 2024
Copy link

melvin-bot bot commented Jun 6, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 6, 2024
Copy link

melvin-bot bot commented Jun 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jun 6, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 12, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Payment Summary

Upwork Job

BugZero Checklist (@twisterdotcom)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@twisterdotcom
Copy link
Contributor

#42073 (comment)

@JmillsExpensify
Copy link

@twisterdotcom mind confirming the payment summary above?

@twisterdotcom
Copy link
Contributor

Payment Summary

Upwork Job

@shubham1206agra
Copy link
Contributor

@twisterdotcom Accepted

@JmillsExpensify
Copy link

$250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design NewFeature Something to build that is a new item.
Projects
Development

No branches or pull requests

8 participants