-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-06-13] [MEDIUM] Add "Schedule a demo" link to the Travel landing page #42776
Comments
Current assignee @twisterdotcom is eligible for the NewFeature assigner, not assigning anyone new. |
@rushatgabhane or @smelaa - would you like to take this one? |
Schedule a demo
link to the Travel landing pageSchedule a demo
link to the Travel landing page
@twisterdotcom i can pick this |
Assigning @shubham1206agra to review too then. |
Triggered auto assignment to @dubielzyk-expensify ( |
I tossed the |
@dannymcclain is there a figma link? i need to know the value of spacing between the buttons. edit: found it here https://www.figma.com/design/rOyUSHbLLyp64emz6WeoPW/Travel?node-id=892-7795&t=5nZ2ixVrRKaCQd8s-0 |
PR ready here - #42864 |
Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Approved the PR 👍 Looking good |
Schedule a demo
link to the Travel landing page
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-06-13. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary
BugZero Checklist (@twisterdotcom)
|
@twisterdotcom mind confirming the payment summary above? |
Payment Summary
|
@twisterdotcom Accepted |
$250 approved for @rushatgabhane |
We need to add a
Schedule a demo
link to the Travel landing page:This is how it should look:
I think this is where the code lives, but I am not 100% certain.
Issue Owner
Current Issue Owner: @twisterdotcomThe text was updated successfully, but these errors were encountered: