Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-06] [HOLD for payment 2024-06-05] iOS- Launch - App crashes at launch on IOS 14 #42656

Closed
1 of 6 tasks
kbecciv opened this issue May 27, 2024 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented May 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.76.1
Reproducible in staging?: y
Reproducible in production?: n
Email or phone of affected tester (no customers): gatantm@gmail.com
Logs:
Bug6493185_1716832351739!New_Expensify-2024-05-27-204355.ips.beta.txt
Issue reported by: Applause - Internal team

Action Performed:

  1. Install the 1.4.76.1 build to iOS 14
  2. Launch the app

Expected Result:

The app launches on all compatible devices

Actual Result:

The app crashes at launch on iOS 14.7 Build 1.4.76.0 works without issues
Comment: Can not reproduce this on the same model running iOS 16.7 nor the iPhone 15 Pro Max, iOS 17.4.1 or the iPhone 8 running iOS 15 so seems iOS 14 specific.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6493185_1716832351757.RPReplay_Final1716831858.mp4

View all open jobs on GitHub

@kbecciv kbecciv added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels May 27, 2024
Copy link

melvin-bot bot commented May 27, 2024

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented May 27, 2024

We think that this bug might be related to #vip-vsb

@mountiny
Copy link
Contributor

@danieldoglas
Copy link
Contributor

Can we raise that minimum version for our App?

All devices that supported iOS 13, iPadOS 13, iOS 14, and iPadOS 14 also support iOS 15 and iPadOS 15.

@mountiny
Copy link
Contributor

Can we raise that minimum version for our App?

We can, but I think we should make a post to discuss it in Slack to get broader agreement

@danieldoglas
Copy link
Contributor

Yeah, I'll do that. I've also asked Fullstory to investigate that crash.

@luacmartins
Copy link
Contributor

This doesn't seem to be related to the API, so gonna remove the web DeployBlocker label

@luacmartins luacmartins removed the DeployBlocker Indicates it should block deploying the API label May 28, 2024
@danieldoglas danieldoglas added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 28, 2024
@danieldoglas
Copy link
Contributor

Discussion is ongoing here: https://expensify.slack.com/archives/C06FWLQE0FR/p1716891784770479 to fix it to version 14.

For now, we'll bump the iOS app min target to version 15.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 28, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 29, 2024
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label May 29, 2024
@melvin-bot melvin-bot bot changed the title iOS- Launch - App crashes at launch on IOS 14 [HOLD for payment 2024-06-05] iOS- Launch - App crashes at launch on IOS 14 May 29, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 29, 2024
Copy link

melvin-bot bot commented May 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-05. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 30, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-05] iOS- Launch - App crashes at launch on IOS 14 [HOLD for payment 2024-06-06] [HOLD for payment 2024-06-05] iOS- Launch - App crashes at launch on IOS 14 May 30, 2024
Copy link

melvin-bot bot commented May 30, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-06. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 4, 2024
Copy link

melvin-bot bot commented Jun 6, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants