Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actionable Whispers] Missing currency categorizing an expense without updating it #42116

Closed
thienlnam opened this issue May 13, 2024 · 6 comments
Assignees
Labels
Daily KSv2

Comments

@thienlnam
Copy link
Contributor

During the investigation of #40266, I noticed that the flows for Categorize/Share also had some of the same issues fetching the modified currency if it wasn't updated. Update the flow and add more tests to verify it doesn't happen to categorized expenses as well

@thienlnam thienlnam added the Daily KSv2 label May 13, 2024
@thienlnam thienlnam self-assigned this May 13, 2024
@melvin-bot melvin-bot bot added the Overdue label May 16, 2024
Copy link

melvin-bot bot commented May 17, 2024

@thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

@thienlnam
Copy link
Contributor Author

This got un-deployed in the fire fix, but should be deployed next week

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 18, 2024
Copy link

melvin-bot bot commented May 21, 2024

@thienlnam Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented May 23, 2024

@thienlnam Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented May 27, 2024

@thienlnam Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@thienlnam
Copy link
Contributor Author

Done!

@melvin-bot melvin-bot bot removed the Overdue label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2
Projects
None yet
Development

No branches or pull requests

1 participant