Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [Details Revamp] Update ReportDetailsPage for Rooms and Groups #42074

Closed
grgia opened this issue May 13, 2024 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@grgia
Copy link
Contributor

grgia commented May 13, 2024

https://docs.google.com/document/d/1-xSZdSZZIuIl0fPO7yypkKfcbWEsnNFAs50ptgL3Gnw/edit#bookmark=id.hexzxly74ri6

Issue OwnerCurrent Issue Owner: @sonialiap
@grgia grgia added Daily KSv2 NewFeature Something to build that is a new item. labels May 13, 2024
@grgia grgia self-assigned this May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented May 13, 2024

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

@cdOut
Copy link
Contributor

cdOut commented May 14, 2024

Hi, I'm Tymoteusz from Software Mansion, the expert agency, and I'd like to work on this issue.

@sonialiap
Copy link
Contributor

@grgia what do we need here? Are you building this or do we we want to find a contributor to work on this?

@melvin-bot melvin-bot bot removed the Overdue label May 22, 2024
@cdOut
Copy link
Contributor

cdOut commented May 22, 2024

I am currently working on it, will put up a PR for it tomorrow.

@grgia
Copy link
Contributor Author

grgia commented Jun 4, 2024

@cdOut what PR is linked to this one?

Copy link

melvin-bot bot commented Jun 22, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Jun 24, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Jun 24, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Jun 24, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 25, 2024
@melvin-bot melvin-bot bot changed the title [Details Revamp] Update ReportDetailsPage for Rooms and Groups [HOLD for payment 2024-07-02] [Details Revamp] Update ReportDetailsPage for Rooms and Groups Jun 25, 2024
Copy link

melvin-bot bot commented Jun 25, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 25, 2024
Copy link

melvin-bot bot commented Jun 25, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-02. 🎊

For reference, here are some details about the assignees on this issue:

  • @cdOut does not require payment (Contractor)

Copy link

melvin-bot bot commented Jun 25, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@cdOut] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@ikevin127
Copy link
Contributor

@sonialiap @grgia I require payment as C+ reviewer of PR: #43251 (comment).

Notes:

  1. The PR had some regressions, Georgia should be able to confirm this.
  2. There are 2 other issues as part of this PR (42075, 42076) where the hold for payment was added as well.

@trjExpensify
Copy link
Contributor

Let's consolidate to one issue to handle payment for the PR that took care of these issues. As the regression period is over, I'm closing this issue and centralising on the one I'm assigned to: #42076

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 3, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-02] [Details Revamp] Update ReportDetailsPage for Rooms and Groups [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [Details Revamp] Update ReportDetailsPage for Rooms and Groups Jul 3, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 3, 2024
Copy link

melvin-bot bot commented Jul 3, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 3, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

  • @cdOut does not require payment (Contractor)

Copy link

melvin-bot bot commented Jul 3, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@cdOut] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
Archived in project
Development

No branches or pull requests

6 participants