[HOLD for payment 2024-09-19][CRITICAL]: Add Pay as Business option for invoices sent to any individual

[cristipaval]

Held on #40438

Part of the Invoicing V0.3 project

Main issue: https://github.com/Expensify/Expensify/issues/341717
Doc section: Invoicing V1
Project: #vip-billpay

Feature Description

Enable the Pay as business option in the App for all individuals and optimistically create a collect workspace and set it as primary workspace, when they are not an admin of the primary workspace.

Manual Test Steps

Automated Tests

Issue Owner

Current Issue Owner: @VickyStash

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[melvin-bot]

Triggered auto assignment to @OfstadC (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[cristipaval]

I added @jjcoffee as the C+ for this issue since he already has a lot of context on this and did great testing recently.

[VickyStash]

Note: I'm going to be OOO tomorrow (15th of Aug).

@cristipaval Please take a look at my questions above when you have a moment

[cristipaval]

• Should I optimistically update primary policy (nvp_expensify_activePolicyID onyx key)?
• Should I optimistically create a whisper message about the created workspace?

@VickyStash yes to both questions from above

[VickyStash]

Updates: I was focused on other issues, but I'm going to make some updates for this one on Monday

[VickyStash]

Minor updates: Implemented active policy id (nvp_expensify_activePolicyID) optimistic update

[VickyStash]

Updates:

• I've included more policy related params to pass to the API
• Started to combine the Draft PR: Add Pay as Business option for invoices sent to any individual #47862

[VickyStash]

Updates:
Waiting for the API updates to open the PR for the review.

[VickyStash]

The PR has been opened for the review

[jjcoffee]

@OfstadC Looks like @cristipaval is on parental leave at the moment, is it possible to get another engineer assigned to review the PR?

[mallenexpensify]

@jjcoffee can you add " 🎀 👀 🎀 C+ reviewed " to assign a new engineer plz? i removed Cristi

[jjcoffee]

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jjcoffee]

Deployed to production Sept 12, so should be due for payment 2024-09-19. Since this is a CRITICAL feature for invoicing, I believe it also qualifies for $500, as on the other invoicing issue I worked on. cc @OfstadC

[OfstadC]

Sounds accurate to me! And we need to pay @jjcoffee and @VickyStash, yes? I'll work on the Upwork offers tomorrow since I don't believe one was created for this yet

[jjcoffee]

@OfstadC Thanks! No need for an Upwork offer for @VickyStash as she is from Callstack.

[OfstadC]

Upwork Job - https://www.upwork.com/ab/applicants/1836405649803524751/job-details

@jjcoffee Could you please link your Upwork profile here? 😃

[OfstadC]

Thanks! I've sent the offer here

If you can propose any necessary regression tests, I can issue payment tomorrow 😃

[jjcoffee]

Regression Test Proposal

1. Sign in to the app as User A.
2. Send invoices to:

• User B - who has no workspaces at all
• User C - who has a primary workspace but he is not an admin of it

3. Log in to the app as User B. Pay the invoice as business
4. Verify that a new primary workspace is created for User B and that they are the admin of it. The invoice should be paid by this workspace, and the room should be turned into a B2B invoice room.
5. Log in to the app as User C. Pay the invoice as business.
6. Verify that a new primary workspace is created for User C and that they are the admin of it. The invoice should be paid by this workspace, and the room should be turned into a B2B invoice room.

Do we agree 👍 or 👎

[jjcoffee]

@OfstadC Offer accepted, thank you!

[OfstadC]

Payment Summary

• Paid @jjcoffee $500 via Upwork