[$250] [HOLD for payment 2024-06-13] [QBO] Prevent the admin from making misconfiguration related to Locations and Vendor Bills / Checks

[hayata-suenaga]

Prevent the admin from making configurations that result in the loss of Location information when expenses are exported to QBO. We will do that in the following two ways:

• When the Location import is enabled, don't display the Vendor Bill or Check on the list of account type options for both reimbursable and non-reimbursable expense types.

• When the Vendor Bill or Check is selected as the export option for either or both of the reimbursable and non-reimbursable expense types, lock the switch button for the Locations import configuration.

Refer to the following sections of the QBO design doc:

• Don't display Vendor Bill or Check on the Reimbursable or Company Card export configuration pages when Location import is enabled.

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017a7e95204bed8567
• Upwork Job ID: 1801201513249071105
• Last Price Increase: 2024-06-13

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[hayata-suenaga]

working on the PR

[melvin-bot]

@rojiphil, @jliexpensify, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Prevent invalid configuration between location and JE selection #41638

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rojiphil] The PR that introduced the bug has been identified. Link to the PR:
• [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rojiphil] Determine if we should create a regression test for this bug.
• [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Bump @rojiphil - is a checklist needed?

Payment Summary

• C+: @rojiphil $250

UPWORKS JOB

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017a7e95204bed8567

[melvin-bot]

Current assignee @rojiphil is eligible for the External assigner, not assigning anyone new.

[rojiphil]

@jliexpensify As this was an improvement, I think no checklist is required.
Accepted Offer. Thanks.

[jliexpensify]

Paid and job closed!