Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Error is displayed when creating conversation with invalid number #41257

Closed
1 of 6 tasks
isagoico opened this issue Apr 29, 2024 · 7 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@isagoico
Copy link

isagoico commented Apr 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.67-3
Reproducible in staging?: Yes
Reproducible in production?: Yes

Issue reported by: Applause - Internal Team

Action Performed:

  1. Click on FAB > Start Chat
  2. Start a chat with the following number - +79585702746
  3. Click on the "Search" icon

Expected Result:

An error should display indicating the user there was an error creating the chat.
Header should display the user details. In this case the phone number "+79585702746"
When clicking in search, the conversation with the error should not display.

Actual Result:

An error is displayed indicating the user that "The provided phone number does not match the country you are currently located at, please use your email address instead."
There's a skeleton loader in the header of the conversation.
The conversation with the error is displayed in search.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image

image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010c028e1ef30e9a46
  • Upwork Job ID: 1785768462241026048
  • Last Price Increase: 2024-05-01
@isagoico isagoico added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 29, 2024
Copy link

melvin-bot bot commented Apr 29, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@isagoico
Copy link
Author

This was found while reviewing the regression tests for this issue - https://github.com/Expensify/Expensify/issues/390645

This issue #38879 had 2 PRs that fixed the following:

@neonbhai
Copy link
Contributor

The error message is sent from the backend:

Screenshot 2024-04-30 at 5 20 34 AM

We can add the Internal label here

@sakluger sakluger added the Internal Requires API changes or must be handled by Expensify staff label May 1, 2024
Copy link

melvin-bot bot commented May 1, 2024

Job added to Upwork: https://www.upwork.com/jobs/~010c028e1ef30e9a46

Copy link

melvin-bot bot commented May 1, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

@sakluger
Copy link
Contributor

sakluger commented May 2, 2024

I posted in Slack asking for an internal engineer to help.

@sakluger
Copy link
Contributor

sakluger commented May 2, 2024

Bsed on the discussion, the error from the backend is correct, but we could handle the situation more clearly.

That being said, this is a vary unlikely edge case, I am going to close so we can focus on higher value bugs.

@sakluger sakluger closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

4 participants