[PAID] [$250] IOU - User is stuck on the same page after navigating to IOU preview link twice offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.66-1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Launch New Expensify app.
2. Go offline.
3. Submit two expenses to a user.
4. Go to expense report.
5. Right click on any expense preview > Copy link.
6. Paste the link and send it.
7. Click on the same link twice.
8. Attempt to go back via back button on the top left.

Expected Result:

User is able to go back to previous page.

Actual Result:

User is stuck on the same page after navigating to IOU preview link twice in offline mode.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6462137_1714080199177.RPReplay_Final1714076785.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016d14b52b4d7afaf4
• Upwork Job ID: 1785888211431084032
• Last Price Increase: 2024-05-09
• Automatic offers:
• dukenv0307 | Reviewer | 0

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[melvin-bot]

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

[strepanier03]

I can't repro with Mac OS/Chrome. Gonna try with Android:Native.

[strepanier03]

Okay, able to repro on Android.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016d14b52b4d7afaf4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[melvin-bot]

@strepanier03, @dukenv0307 Huh... This is 4 days overdue. Who can take care of this?

[strepanier03]

Urgency is polish and this is unlikely to be worked on for a week or so at best.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@strepanier03 @dukenv0307 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@strepanier03, @dukenv0307 Huh... This is 4 days overdue. Who can take care of this?

[narefyev91]

Hey! I'm Nicolay from Callstack - will check this issue - please assign to me

[melvin-bot]

@strepanier03, @dukenv0307 Still overdue 6 days?! Let's take care of this!

[strepanier03]

Thank you @narefyev91 - Assigned.

[narefyev91]

Found a root case of the issue - will provide a draft PR today

[melvin-bot]

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix linked message visibility in offline mode #42396
• Fix linked message visibility in offline mode #42628

If no regressions arise, payment will be issued on 2024-06-05. 🎊

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @dukenv0307 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
• [@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@dukenv0307] Determine if we should create a regression test for this bug.
• [@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dukenv0307]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test:

1. Launch New Expensify app.
2. Go offline.
3. Submit two expenses to a user.
4. Go to expense report.
5. Right click on any expense preview > Copy link.
6. Paste the link and send it.
7. Click on the same link
8. Verify that you can see messages - and linked message will be highlighted
9. Verify that user can go back and not stuck on the same screen

Do we 👍 or 👎

[melvin-bot]

@strepanier03, @MariaHCD, @narefyev91, @dukenv0307 Huh... This is 4 days overdue. Who can take care of this?

[strepanier03]

@dukenv0307 - I've paid you and closed the contract, thanks!

Closing this out now.