Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-13] Group Chats Front end clean up & refactors #40187

Closed
7 tasks
marcaaron opened this issue Apr 12, 2024 · 45 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Planning Changes still in the thought process Weekly KSv2

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Apr 12, 2024

@s77rt I would say this list is not exclusive. If you have any ideas on how to improve the code further we can take an approach where you propose what we should change, I'll review that, and we can go from there and add things to the list below.

Otherwise, this is the minimum expectation:

Issue OwnerCurrent Issue Owner: @adelekennedy
@marcaaron marcaaron added Planning Changes still in the thought process Weekly KSv2 labels Apr 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@s77rt
Copy link
Contributor

s77rt commented Apr 23, 2024

No update yet

@melvin-bot melvin-bot bot removed the Overdue label Apr 23, 2024
@marcaaron marcaaron changed the title [HOLD Front End PR 2] Group Chats Front end clean up & refactors Group Chats Front end clean up & refactors Apr 30, 2024
@marcaaron
Copy link
Contributor Author

This can come off HOLD now.

@melvin-bot melvin-bot bot added the Overdue label May 8, 2024
@s77rt
Copy link
Contributor

s77rt commented May 8, 2024

I didn't get a chance to look into this yet

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2024
@melvin-bot melvin-bot bot added the Overdue label May 17, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 Overdue labels May 18, 2024
@s77rt
Copy link
Contributor

s77rt commented May 18, 2024

Raised a PR for the first list item (navigateToMostRecentReport simplification)

@s77rt s77rt mentioned this issue May 18, 2024
50 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 18, 2024
@s77rt
Copy link
Contributor

s77rt commented May 18, 2024

Raised a PR for the second list item (combining report name routes)

@s77rt s77rt mentioned this issue Jun 4, 2024
50 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 4, 2024
@s77rt
Copy link
Contributor

s77rt commented Jun 4, 2024

Raised a PR for the remaining tasks:

  • NewChatConfirmPage - move or useCallback for these functions: Done
  • ReportDetailsPage - Capture all avatar options in the renderAvatar: This was handled here
  • getReportName() refactor: getReportName already supports group chat, nothing to do here
  • newChatNameForm Onyx key - seems this is not working as intended: False positive. This is working as expected, we are not using draft here and the empty newChatNameForm object shown in the video is for the form state i.e. isLoading, errors. Since it's not loading and we don't have errors it's empty.
  • Ensure that we can not access an invalid member page: Done

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 6, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jun 27, 2024
@s77rt
Copy link
Contributor

s77rt commented Jun 27, 2024

@marcaaron Almost, it requires your review 👀 #42365

@melvin-bot melvin-bot bot added the Overdue label Jul 1, 2024
@adelekennedy
Copy link

adelekennedy commented Jul 1, 2024

It looks like that last PR was just approved and merged!

Final payout is due to @fedirjh

@melvin-bot melvin-bot bot removed the Overdue label Jul 1, 2024
@adelekennedy adelekennedy reopened this Jul 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 4, 2024
Copy link

melvin-bot bot commented Jul 5, 2024

@s77rt, @marcaaron, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@adelekennedy
Copy link

not deployed to prod yet

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue Daily KSv2 labels Jul 8, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-13] Group Chats Front end clean up & refactors [HOLD for payment 2024-07-17] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-13] Group Chats Front end clean up & refactors Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

  • @s77rt requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Jul 10, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
  • [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@s77rt] Determine if we should create a regression test for this bug.
  • [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@s77rt
Copy link
Contributor

s77rt commented Jul 15, 2024

Checklist ^ does not apply here. This was just a cleanup task.

Issue can be closed after paying out @fedirjh

@adelekennedy
Copy link

2 days away from payment!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-17] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-13] Group Chats Front end clean up & refactors [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-13] Group Chats Front end clean up & refactors Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

  • @s77rt requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Jul 15, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
  • [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@s77rt] Determine if we should create a regression test for this bug.
  • [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Copy link

melvin-bot bot commented Jul 22, 2024

Payment Summary

Upwork Job

  • Reviewer: @s77rt owed $250 via NewDot

BugZero Checklist (@adelekennedy)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Jul 24, 2024
@marcaaron
Copy link
Contributor Author

Are we waiting for anything else here?

@adelekennedy
Copy link

adelekennedy commented Jul 25, 2024

Payouts due:

@JmillsExpensify
Copy link

$250 approved for @fedirjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Planning Changes still in the thought process Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants