Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Removing distance default category "Updated" message displayed Instead of "removed" #40112

Closed
1 of 6 tasks
kbecciv opened this issue Apr 11, 2024 · 5 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Apr 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.62-1
Reproducible in staging?: y
Reproducible in production?: y
Issue found when executing PR: #39643
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to /settings/workspaces//distance-rates
  2. Tap Settings
  3. Change the default category
  4. Now uncheck the selected category
  5. Navigate to #admin report of collect Workspace
  6. Note the policy change log message says updated the Distance default category from "..." to "..." instead of "removed distance default category"

Expected Result:

Message "removed distance default category" should be displayed after removing distance default category

Actual Result:

Removing distance default category "Updated" message displayed Instead of "removed"

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6445711_1712830164614.2024-04-11_15-08-19.mp4

Screenshot 2024-04-11 at 1 21 31 AM

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 11, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@kbecciv
Copy link
Author

kbecciv commented Apr 11, 2024

We think that this bug might be related to #wave-control

@kbecciv
Copy link
Author

kbecciv commented Apr 11, 2024

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@dragnoir
Copy link
Contributor

BE issue. The backend is sending this message back (updated the Distance default category from "Advertising" to "") when the same item is selected.

@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
@stephanieelliott
Copy link
Contributor

I think this behavior makes sense, I know the " " could seem off but in this context I think it communicates a null value (which it is). So I don't think this is a bug per se and since it's affecting only one platform I don't think it is worth changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants