-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement message-type Android push notifications #4007
Comments
This will require a Native implementation. I saw we talked with the UA team, and they provided an example that we can adapt to what we need. I'll work on this next week. I believe we can build something nice with the current payload we're getting with each notification. |
This issue has not been updated in over 15 days. @HorusGoul eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Moving it back to Weekly, we haven't been able to focus on this too much because of allocations. @Julesssss still has to finish reviewing the PR 😄 |
Yep, sorry I've just been too busy with allocations. I want to test against a release build which is fine, but takes some setup time. Will get to this soon! |
I have just built the release build and have started my review, again sorry for the delay here 😔 |
This issue has not been updated in over 15 days. @HorusGoul eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Receive a push notification on Android.
Expected Result:
Notifications should appear similar to how they do in Slack:
However: We do not yet need the quick-reply ability in this notification, because it is not yet supported by Airship, and greatly increases the complexity of the task.
Actual Result:
Push notifications look clunky and text-heavy:
Platform:
This is an Android-specific issue.
Version Number:
1.0.77-2
Notes/Photos/Videos: Check out our internal Slack channel with Airship for implementation details and support. Specifically starting here.
The text was updated successfully, but these errors were encountered: