Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement message-type Android push notifications #4007

Closed
roryabraham opened this issue Jul 13, 2021 · 6 comments
Closed

Implement message-type Android push notifications #4007

roryabraham opened this issue Jul 13, 2021 · 6 comments
Assignees
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@roryabraham
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Receive a push notification on Android.

Expected Result:

Notifications should appear similar to how they do in Slack:

image

  • The user's name should be displayed
  • The user's avatar should be displayed
  • We can nix the "New message from $user" prefix
    However: We do not yet need the quick-reply ability in this notification, because it is not yet supported by Airship, and greatly increases the complexity of the task.

Actual Result:

Push notifications look clunky and text-heavy:

image

Platform:

This is an Android-specific issue.

Version Number: 1.0.77-2
Notes/Photos/Videos: Check out our internal Slack channel with Airship for implementation details and support. Specifically starting here.

@roryabraham roryabraham added Engineering Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Jul 13, 2021
@HorusGoul HorusGoul self-assigned this Jul 22, 2021
@HorusGoul
Copy link
Contributor

This will require a Native implementation. I saw we talked with the UA team, and they provided an example that we can adapt to what we need.

I'll work on this next week. I believe we can build something nice with the current payload we're getting with each notification.

@MelvinBot
Copy link

This issue has not been updated in over 15 days. @HorusGoul eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@MelvinBot MelvinBot added Monthly KSv2 and removed Weekly KSv2 labels Aug 25, 2021
@HorusGoul HorusGoul added Weekly KSv2 and removed Monthly KSv2 labels Aug 26, 2021
@HorusGoul
Copy link
Contributor

Moving it back to Weekly, we haven't been able to focus on this too much because of allocations. @Julesssss still has to finish reviewing the PR 😄

@Julesssss
Copy link
Contributor

Yep, sorry I've just been too busy with allocations. I want to test against a release build which is fine, but takes some setup time. Will get to this soon!

@Julesssss
Copy link
Contributor

I have just built the release build and have started my review, again sorry for the delay here 😔

@MelvinBot MelvinBot added Monthly KSv2 and removed Weekly KSv2 labels Sep 20, 2021
@MelvinBot
Copy link

This issue has not been updated in over 15 days. @HorusGoul eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@botify botify closed this as completed Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants