Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-25] [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Scan - Camera is seen as black screen and error occurs after tap capture icon #39285

Closed
1 of 6 tasks
lanitochka17 opened this issue Mar 29, 2024 · 29 comments · Fixed by #39396
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #37817

Action Performed:

Prerequisite: Reset permission of the app

  1. Go to FAB > Request Money > Scan
  2. Verify that the camera request permission prompt doesn't appear
  3. Click on the Continue button or capture icon
  4. Verify that the camera request permission prompt appears
  5. Accept the permission
  6. Tap "Manual" tab
  7. Close the app
  8. Open the app
  9. Go to FAB > Request Money
  10. Tap Scan tab and verify the screen is black
  11. Tap Capture icon

Expected Result:

Camera is seen correctly and user can capture photos

Actual Result:

Camera is seen as black screen and error occurs after tap Capture icon

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431840_1711732535254.mobizen_20240329_200259.mp4
Bug6431840_1711732535268.mobizen_20240329_195807.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@deetergp
Copy link
Contributor

I suspect this PR is what introduced the regression #37483

@mountiny
Copy link
Contributor

@deetergp can you create a revert PR? This seems like something we cannot CP fix for

@deetergp
Copy link
Contributor

deetergp commented Apr 1, 2024

@mountiny Revert PR is here. I think we might need someone with a physical android device to test it to see if it resolves this and @johnmlee101's blocker.

@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2024
@johnmlee101
Copy link
Contributor

Yeah agreed, if we're reverting I'll need confirmation on that, although very high chance it will fix 👍

@Monicahinga
Copy link

I have seen the black screen. I can help with the testing once the revert PR is done.
I have a physical Android device to check them.

Copy link

melvin-bot bot commented Apr 1, 2024

📣 @Monicahinga! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@Monicahinga
Copy link

Contributor details
Your Expensify account email: onicahinga25@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~011654b49fbd60bd8f

Copy link

melvin-bot bot commented Apr 1, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@marcaaron
Copy link
Contributor

Asked for a re-test here

@kavimuru
Copy link

kavimuru commented Apr 1, 2024

Issue is fixed.

video_2024-04-01_17-52-58.mp4

@deetergp
Copy link
Contributor

deetergp commented Apr 1, 2024

Looks like we're good. Closing!

@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 2, 2024
@Beamanator Beamanator reopened this Apr 2, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 2, 2024
@melvin-bot melvin-bot bot changed the title Scan - Camera is seen as black screen and error occurs after tap capture icon [HOLD for payment 2024-04-09] Scan - Camera is seen as black screen and error occurs after tap capture icon Apr 2, 2024
Copy link

melvin-bot bot commented Apr 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 2, 2024
Copy link

melvin-bot bot commented Apr 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-09. 🎊

Copy link

melvin-bot bot commented Apr 2, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@deetergp] The PR that introduced the bug has been identified. Link to the PR:
  • [@deetergp] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@deetergp] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@deetergp] Determine if we should create a regression test for this bug.
  • [@deetergp] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@mountiny
Copy link
Contributor

mountiny commented Apr 2, 2024

@mrousavy based on QA this was repro in Realme GT2 PRO device

@mrousavy
Copy link
Contributor

mrousavy commented Apr 2, 2024

maybe the GPU preview view is faulty? I'll try to reproduce

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 8, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-04-09] Scan - Camera is seen as black screen and error occurs after tap capture icon [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Scan - Camera is seen as black screen and error occurs after tap capture icon Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-15. 🎊

Copy link

melvin-bot bot commented Apr 8, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@deetergp] The PR that introduced the bug has been identified. Link to the PR:
  • [@deetergp] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@deetergp] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@deetergp] Determine if we should create a regression test for this bug.
  • [@deetergp] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@chrispader
Copy link
Contributor

This issue got fixed in #39854

@Julesssss
Copy link
Contributor

Fix merged, handling C_ payment in the original issue: #38796

Copy link

melvin-bot bot commented Apr 11, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 18, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Scan - Camera is seen as black screen and error occurs after tap capture icon [HOLD for payment 2024-04-25] [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Scan - Camera is seen as black screen and error occurs after tap capture icon Apr 18, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-25. 🎊

Copy link

melvin-bot bot commented Apr 18, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@deetergp] The PR that introduced the bug has been identified. Link to the PR:
  • [@deetergp] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@deetergp] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@deetergp] Determine if we should create a regression test for this bug.
  • [@deetergp] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.