[Hold for Payment 11 August] [Crash] App crashes on directly opening the user details

[parasharrajat]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any 1:1 conversation on E.cash.
2. Click the Chat title.
3. User details page should open.
4. Reload the page on the web.

Expected Result:

App Should not crash.

Actual Result:

On local we see error 404 page not found and on staging App crashes.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
go back to the Home page and then navigate to the user details.

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web ✔️

Version Number: latest
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

crash.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[parasharrajat]

Explanation

1. I think that the URL for the details page is wrong and it leads to a page crash. There is an escaped @ in the URL which is the main issue.

Proposal

1. We have two choices
   a. We either override the URL parsing and then handle this type of URL manually.
   b. We change the URL to something else. https://staging.expensify.cash/details/:login to https://staging.expensify.cash/details?login=:login.

I am a little unsure of the a but b works great. Suggestions are welcomed.

[laurenreidexpensify]

sorry @parasharrajat I missed this one - would you be able to confirm if it's still an issue?

[parasharrajat]

Yes. Try opening this URL. Then open the chat with Matt and click on the chat header to see details. If this works, the former should work.

[laurenreidexpensify]

@parasharrajat I'm struggling to replicate this - can you record this happening so I understand a bit better? Thanks!

[parasharrajat]

@laurenreidexpensify take a look at this video. let me know if it is still unclear to you.

crash.mp4

[laurenreidexpensify]

ah perfect thanks - yeah just reproduced and observed same behaviour. Sending this to our engineering team for review 👍🏽

[MelvinBot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[laurenreidexpensify]

@chiragsalian can you pls review triage review this today so we can move this to upwork and get an external contributor to fix? thanks

[chiragsalian]

Yup, was able to reproduce the same issue. Feel free to post this on upwork and yeah @parasharrajat your proposal 1.b sounds good to me 👍

[laurenreidexpensify]

@parasharrajat post live on Upwork here https://www.upwork.com/jobs/~01e0e7e6f35535026c so I can hire you, assuming you want to move ahead to PR on this one?

[parasharrajat]

Hi @laurenreidexpensify. It is done. PR will be pushed shortly.

[laurenreidexpensify]

@parasharrajat is there PR for this one yet?

[parasharrajat]

It is ready but I am waiting for some clarification about the issue with react-navigation before creating the PR.

[laurenreidexpensify]

No regressions - paid 👍🏽