Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Simplified Collect][Tags] - "Members must tag all spend" switch is toggled back on after refreshing page #38188

Closed
6 tasks done
lanitochka17 opened this issue Mar 12, 2024 · 8 comments
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.51-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #37755

Action Performed:

Precondition:

  • User is an owner of Collect workspace
  • The Collect workspace has tags
  • "People must tag expenses" is enabled on Old Dot
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Collect workspace
  3. Go to Tags
  4. Click Settings
  5. Toggle off "Members must tag all spend" switch
  6. Close the settings RHP
  7. Refresh the page
  8. Click Settings

Expected Result:

"Members must tag all spend" switch will remain toggled off

Actual Result:

"Members must tag all spend" switch is toggled back on after refreshing the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6411610_1710280159625.20240313_054753.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 12, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 12, 2024

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

@jasperhuangg FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@mkhutornyi
Copy link
Contributor

This is known and still WIP, not blocker

@luacmartins
Copy link
Contributor

I agree this is NAB since this is still WIP

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Mar 12, 2024
@luacmartins
Copy link
Contributor

Closing in favor of #38192

@luacmartins luacmartins added Daily KSv2 and removed Hourly KSv2 labels Mar 22, 2024
@luacmartins luacmartins reopened this Mar 22, 2024
@luacmartins luacmartins changed the title Tags - "Members must tag all spend" switch is toggled back on after refreshing page [Simplified Collect][Tags] - "Members must tag all spend" switch is toggled back on after refreshing page Mar 22, 2024
@yuwenmemon yuwenmemon added the Reviewing Has a PR in review label Mar 22, 2024
@trjExpensify
Copy link
Contributor

Why did yah reopen it? Do we have more to go here?

@luacmartins
Copy link
Contributor

Yea, it was this PR, but it has been merged and deployed so we're good to close agian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
Archived in project
Development

No branches or pull requests

6 participants