Expense - Two transaction threads in LHN when creating expense with violation offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.50-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is an employee of Collect workspace
• The Collect workspace has toggled on "People must categorize expenses" for Categories on Old Dot

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Go offline
4. Create a manual request without category
5. Go to request details page

Expected Result:

There will be only one transaction thread in LHN

Actual Result:

There are two transaction threads in LHN. One is grayed out, the other one is not grayed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6410248_1710189778492.20240312_043615.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #wave-collect
CC @trjExpensify

[lanitochka17]

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[trjExpensify]

It could well be related to work for #wave-control and violations, though valid in #wave-collect as well. @abekkala will be curious on a reproduction here - we shouldn't be creating two transaction threads when there's a violation. CC: @JmillsExpensify @cead22 to put on your radar as well!

[bernhardoj]

I think this is already fixed in #37232

[trjExpensify]

Ah perfect, let's close it then! :)